Skip to content

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jul 15, 2024

Update API from slack-api-ref.
Rev: 3ec3c10
Date: 2025-02-08

@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from 4aceb86 to c985b59 Compare July 15, 2024 23:21
@coveralls
Copy link

coveralls commented Jul 15, 2024

Pull Request Test Coverage Report for Build 13220174908

Details

  • 109 of 122 (89.34%) changed or added relevant lines in 10 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 89.348%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/slack/web/api/endpoints/assistant_threads.rb 17 20 85.0%
lib/slack/web/api/endpoints/admin_conversations.rb 7 11 63.64%
lib/slack/web/api/endpoints/conversations_requestSharedInvite.rb 10 16 62.5%
Files with Coverage Reduction New Missed Lines %
lib/slack/web/api/endpoints/admin_users_session.rb 1 64.29%
lib/slack/web/api/endpoints/files.rb 8 45.45%
Totals Coverage Status
Change from base Build 13217187420: -0.2%
Covered Lines: 5561
Relevant Lines: 6224

💛 - Coveralls

@github-actions github-actions bot force-pushed the automated-api-update branch from c985b59 to 011de8b Compare July 16, 2024 23:22
@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from 011de8b to 6055b07 Compare July 16, 2024 23:22
@github-actions github-actions bot force-pushed the automated-api-update branch from 6055b07 to 1e2a48d Compare July 17, 2024 23:22
@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from 1e2a48d to 71fff43 Compare July 17, 2024 23:22
@github-actions github-actions bot force-pushed the automated-api-update branch from 71fff43 to a4e3f3f Compare July 19, 2024 07:18
@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from a4e3f3f to 1a881ce Compare July 19, 2024 07:18
@github-actions github-actions bot force-pushed the automated-api-update branch from 1a881ce to d5b146a Compare July 19, 2024 23:21
@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from d5b146a to c21103f Compare July 19, 2024 23:21
@github-actions github-actions bot force-pushed the automated-api-update branch from c21103f to 0cba24a Compare July 20, 2024 23:20
@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from 0cba24a to 027d25c Compare July 20, 2024 23:20
@github-actions github-actions bot force-pushed the automated-api-update branch from 027d25c to a2e3295 Compare July 21, 2024 23:21
@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from a2e3295 to 4697add Compare July 21, 2024 23:21
@github-actions github-actions bot force-pushed the automated-api-update branch from 4697add to 93f41f4 Compare July 22, 2024 23:20
@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from 93f41f4 to 50768eb Compare July 22, 2024 23:20
@github-actions github-actions bot force-pushed the automated-api-update branch from 50768eb to 09b14b8 Compare July 23, 2024 23:22
@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from 09b14b8 to 8022226 Compare July 23, 2024 23:22
@github-actions github-actions bot force-pushed the automated-api-update branch from 8022226 to 5678706 Compare July 24, 2024 23:21
@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from 5678706 to d1753f9 Compare July 24, 2024 23:21
@github-actions github-actions bot force-pushed the automated-api-update branch from d1753f9 to f41bf5e Compare July 25, 2024 23:22
@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from f41bf5e to 69e712a Compare July 25, 2024 23:22
@github-actions github-actions bot force-pushed the automated-api-update branch from 69e712a to 02cec31 Compare July 26, 2024 23:20
@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from 02cec31 to 6260b65 Compare July 26, 2024 23:20
@github-actions github-actions bot force-pushed the automated-api-update branch from 6260b65 to e0c42c1 Compare July 27, 2024 23:22
@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from e0c42c1 to eed2e25 Compare July 27, 2024 23:22
@github-actions github-actions bot force-pushed the automated-api-update branch from eed2e25 to f8d8d27 Compare July 28, 2024 23:21
@slack-ruby-ci-bot slack-ruby-ci-bot bot force-pushed the automated-api-update branch from f8d8d27 to 017adee Compare July 28, 2024 23:21
@github-actions github-actions bot force-pushed the automated-api-update branch from 017adee to 0c20b72 Compare July 29, 2024 23:20
@gregsaab
Copy link
Contributor

@dblock can this be merged in prior to file_upload_v2?

@dblock
Copy link
Collaborator

dblock commented Jan 30, 2025

@gregsaab I usually do this one before every release, does it need to be?

For file upload v2 I think it's really a utility method that wraps calling an API and doing some more work. It's neither a mixin (something used in many places) nor a patch (something that changes an existing method), so maybe we need a new "helpers" folder/concept (open to other names)?

@gregsaab
Copy link
Contributor

@gregsaab I usually do this one before every release, does it need to be?

For file upload v2 I think it's really a utility method that wraps calling an API and doing some more work. It's neither a mixin (something used in many places) nor a patch (something that changes an existing method), so maybe we need a new "helpers" folder/concept (open to other names)?

When considering the patch approach to adding this method, it seemed wise to have that merged in before making a patch. But, it's not necessary given helper approach.

@github-actions github-actions bot force-pushed the automated-api-update branch from 6669770 to c77626f Compare January 30, 2025 23:22
@github-actions github-actions bot force-pushed the automated-api-update branch from 92963fb to a1ac51b Compare January 31, 2025 23:21
@github-actions github-actions bot force-pushed the automated-api-update branch from 8293364 to 38bd0fd Compare February 1, 2025 23:21
@github-actions github-actions bot force-pushed the automated-api-update branch from 916b18b to 23c3a08 Compare February 2, 2025 23:21
@github-actions github-actions bot force-pushed the automated-api-update branch from eeb4182 to 54b6072 Compare February 3, 2025 23:21
@github-actions github-actions bot force-pushed the automated-api-update branch from 4ceb94f to ad67e08 Compare February 4, 2025 23:21
@github-actions github-actions bot force-pushed the automated-api-update branch from dd2e51e to ffffe84 Compare February 5, 2025 23:22
@github-actions github-actions bot force-pushed the automated-api-update branch from 2ba69e4 to 6339dcc Compare February 6, 2025 23:22
@github-actions github-actions bot force-pushed the automated-api-update branch from 8257903 to 17f6891 Compare February 7, 2025 23:21
@github-actions github-actions bot force-pushed the automated-api-update branch from 9f10d6a to 6b76860 Compare February 8, 2025 16:20
@github-actions github-actions bot force-pushed the automated-api-update branch from 2f7080a to 481a0ec Compare February 8, 2025 23:22
@dblock dblock merged commit c9beb73 into master Feb 9, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants