Decode avros in worker tasks, not main kafka thread #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot in the main kafka reading sequence
… type cimpl.Message and can't be serialized by Dask
… we attempt decoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the benchmarking we did to compare boom to Kowalski, it's clear that Kowalski is limited by how we read from kafka before submitting alerts for processing. At the moment, in one thread we read from kafka + decode the message + check if alerts are already processed, all sequentially before we submit an alert for processing by one of the workers in the cluster.
This means that we do a lot of work single threaded before submitting anything to the workers for processing, when that work could be done by the workers in order to parallelize it.
In this PR, we edit the kafka reading logic to only poll messages and directly submit them for processing. Then, workers themselves are in charge of decoding the avro data and checking if an alert is already processed (i.e. already in the DB).