Skip to content

feat: add file-exists action #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 5, 2025
Merged

feat: add file-exists action #40

merged 9 commits into from
May 5, 2025

Conversation

FidelusAleksander
Copy link
Contributor

Changes

Checklist

  • I have added or updated appropriate labels to this PR
  • I have tested my changes
  • I have updated the documentation if needed

@Copilot Copilot AI review requested due to automatic review settings May 5, 2025 11:18
@github-actions github-actions bot added the maintenance Maintenance work on the repository label May 5, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new composite GitHub action to check for the existence of a file in the repository.

  • Adds a new composite action defined in actions/file-exists/action.yml.
  • Provides a workflow (.github/workflows/_test-file-exists-action.yml) to test both success and failure scenarios for the action.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
actions/file-exists/action.yml Adds a composite action to verify if a file exists in the repository.
.github/workflows/_test-file-exists-action.yml Adds tests to confirm the proper behavior of the new action.
Comments suppressed due to low confidence (1)

actions/file-exists/action.yml:18

  • The 'core' module is used without being imported or defined. Consider importing '@actions/core' or using an alternative method such as throwing an error to properly fail the action.
core.setFailed(`❌ File does not exist: ${filePath}`);

@chriswblake
Copy link
Member

One more comment: I would add a very basic README providing usage and an example. Also list it in your main readme.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 5, 2025
@FidelusAleksander FidelusAleksander removed documentation Improvements or additions to documentation maintenance Maintenance work on the repository labels May 5, 2025
@FidelusAleksander
Copy link
Contributor Author

Note to self: update release-drafter configuration with a new section for actions + labeler with a new label

@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Maintenance work on the repository labels May 5, 2025
@FidelusAleksander FidelusAleksander merged commit bab2bb6 into main May 5, 2025
12 checks passed
@FidelusAleksander FidelusAleksander deleted the file-exists-action branch May 5, 2025 17:03
assetsbuffer added a commit to assetsbuffer/exercise-toolkit that referenced this pull request May 6, 2025
@FidelusAleksander FidelusAleksander added actions Changes to GitHub Actions shared by this repository and removed documentation Improvements or additions to documentation maintenance Maintenance work on the repository labels May 6, 2025
@FidelusAleksander FidelusAleksander added the bump-minor Corresponds to minor SemVer release label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions Changes to GitHub Actions shared by this repository bump-minor Corresponds to minor SemVer release
Development

Successfully merging this pull request may close these issues.

2 participants