Fixed issue where saveImageToFs was still saving files after promise … #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was returned. Migrated listr to listr2. Introduced option createSubdirectories to create folder structure from component path instead of replacing slashes with underscore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…was returned. Migrated listr to listr2. Introduced option createSubdirectories to create folder structure from component path instead of replacing slashes with underscore.
Let me know if you want me to split this PR into the bugfix & the new option "createSubdirectories".
Also I'd recommend you to update all your dependencies, some of them are very outdated.