Use getScopes (#1428)

Author: fisker

rules/no-unused-properties.js

@@ -1,4 +1,5 @@
 'use strict';
+const getScopes = require('./utils/get-scopes.js');
 
 const MESSAGE_ID = 'no-unused-properties';
 const messages = {
@@ -211,25 +212,16 @@ const create = context => {
 		}
 	};
 
-	const checkChildScopes = scope => {
-		for (const childScope of scope.childScopes) {
-			checkScope(childScope);
-		}
-	};
-
-	const checkScope = scope => {
-		if (scope.type === 'global') {
-			return checkChildScopes(scope);
-		}
-
-		checkVariables(scope);
-
-		return checkChildScopes(scope);
-	};
-
 	return {
 		'Program:exit'() {
-			checkScope(context.getScope());
+			const scopes = getScopes(context.getScope());
+			for (const scope of scopes) {
+				if (scope.type === 'global') {
+					continue;
+				}
+
+				checkVariables(scope);
+			}
 		},
 	};
 };

rules/prefer-ternary.js

@@ -7,6 +7,7 @@ const getIndentString = require('./utils/get-indent-string.js');
 const {getParenthesizedText} = require('./utils/parentheses.js');
 const shouldAddParenthesesToConditionalExpressionChild = require('./utils/should-add-parentheses-to-conditional-expression-child.js');
 const {extendFixRange} = require('./fix/index.js');
+const getScopes = require('./utils/get-scopes.js');
 
 const messageId = 'prefer-ternary';
 
@@ -40,11 +41,6 @@ function getNodeBody(node) {
 	return node;
 }
 
-const getScopes = scope => [
-	scope,
-	...scope.childScopes.flatMap(scope => getScopes(scope)),
-];
-
 const isSingleLineNode = node => node.loc.start.line === node.loc.end.line;
 
 const create = context => {