prefer-string-slice: Use getParenthesizedText (#1425)

Author: fisker

rules/prefer-string-slice.js

@@ -1,5 +1,6 @@
 'use strict';
 const eslintTemplateVisitor = require('eslint-template-visitor');
+const {getParenthesizedText} = require('./utils/parentheses.js');
 
 const MESSAGE_ID_SUBSTR = 'substr';
 const MESSAGE_ID_SUBSTRING = 'substring';
@@ -42,20 +43,6 @@ const isLikelyNumeric = node => isLiteralNumber(node) || isLengthProperty(node);
 const create = context => {
 	const sourceCode = context.getSourceCode();
 
-	const getNodeText = node => {
-		const text = sourceCode.getText(node);
-		const before = sourceCode.getTokenBefore(node);
-		const after = sourceCode.getTokenAfter(node);
-		if (
-			(before && before.type === 'Punctuator' && before.value === '(') &&
-			(after && after.type === 'Punctuator' && after.value === ')')
-		) {
-			return `(${text})`;
-		}
-
-		return text;
-	};
-
 	return templates.visitor({
 		[substrCallTemplate](node) {
 			const objectNode = substrCallTemplate.context.getMatch(objectVariable);
@@ -113,7 +100,7 @@ const create = context => {
 			}
 
 			if (sliceArguments) {
-				const objectText = getNodeText(objectNode);
+				const objectText = getParenthesizedText(objectNode, sourceCode);
 				const optionalMemberSuffix = node.callee.optional ? '?' : '';
 				const optionalCallSuffix = node.optional ? '?.' : '';
 
@@ -181,7 +168,7 @@ const create = context => {
 			}
 
 			if (sliceArguments) {
-				const objectText = getNodeText(objectNode);
+				const objectText = getParenthesizedText(objectNode, sourceCode);
 				const optionalMemberSuffix = node.callee.optional ? '?' : '';
 				const optionalCallSuffix = node.optional ? '?.' : '';
 

test/prefer-string-slice.mjs

@@ -150,11 +150,11 @@ test({
 		{
 			code: outdent`
 				const uri = 'foo';
-				(uri || '').substr(1)
+				((uri || '')).substr(1)
 			`,
 			output: outdent`
 				const uri = 'foo';
-				(uri || '').slice(1)
+				((uri || '')).slice(1)
 			`,
 			errors: errorsSubstr,
 		},
@@ -292,12 +292,12 @@ test.typescript({
 		{
 			code: outdent`
 				function foo() {
-					return (bar as string).substring(3);
+					return ((bar as string)).substring(3);
 				}
 			`,
 			output: outdent`
 				function foo() {
-					return (bar as string).slice(3);
+					return ((bar as string)).slice(3);
 				}
 			`,
 			errors: errorsSubstring,