examples/perf: Add an arch flag to run only on x86_64 #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow lints for "unnecessary transmutes" for now.
Resoolve lints for "unnecessary transmutes" for now.
Licenser
reviewed
Jul 8, 2025
| @@ -1223,7 +1223,7 @@ pub(crate) use unlikely; | |||
| #[allow(unused_macros)] | |||
| macro_rules! static_cast_i32 { | |||
| ($v:expr_2021) => { | |||
| ::std::mem::transmute::<u32, i32>($v) | |||
| u32::cast_signed($v.wrapping_neg()) | |||
There was a problem hiding this comment.
The wrapping_neg should definitely not be here. The macro name gives no indication that it also negates the number. This would be highly misleading and potentially lead to bugs down the road.
Also cast_signed requires a newer rust version which might be OK but needs careful consideration as it is a backwards compatibility breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow lints for "unnecessary transmutes" for now.