Skip to content

Manually implement deserialize #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

pawanjay176
Copy link
Member

Enforce length constraints after serde deserializing. Add tests

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 57.24%. Comparing base (b7f47d9) to head (a4ab654).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fixed_vector.rs 80.00% 2 Missing ⚠️
src/variable_list.rs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   55.55%   57.24%   +1.68%     
==========================================
  Files           8        8              
  Lines         270      290      +20     
==========================================
+ Hits          150      166      +16     
- Misses        120      124       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful. Not sure why the code coverage tool is complaining about that PhantomData line or the format string. I suspect both are optimised out, which is fine.

@michaelsproul michaelsproul merged commit 03d4826 into sigp:main Feb 14, 2025
7 checks passed
This was referenced Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants