Run CI tests only recent forks #8271
Merged
+6
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
added
test improvement
|
Some required checks have failed. Could you please take a look @pawanjay176? 🙏 |
mergify
bot
added
waiting-on-author
mergify
bot
added
ready-for-review
michaelsproul
previously requested changes
Oct 27, 2025
Makefile
Outdated
|
|
||
| # List of all hard forks. This list is used to set env variables for several tests so that | ||
| # they run for different forks. | ||
| FORKS=phase0 altair bellatrix capella deneb electra fulu gloas |
There was a problem hiding this comment.
May as well delete the FORKS variable, as it is now unused
michaelsproul
added
waiting-on-author
jimmygchen
approved these changes
Oct 29, 2025
There was a problem hiding this comment.
Looks good and I've pushed @michaelsproul 's suggested changes.
jimmygchen
added
ready-for-merge
|
PR to run all prior forks nightly here: #8319 |
6 tasks
6 tasks
eserilev
pushed a commit
to eserilev/lighthouse
that referenced
this pull request
Oct 30, 2025
Partially addresses sigp#8248 Run the beacon chain, http and network tests only for recent forks instead of everything from phase 0. Also added gloas also to the recent forks list. I thought that would be a good way to know if changes in the current fork affect future forks. Not completely sure if we should run for future forks, but added it so that we can discuss here. Co-Authored-By: Pawan Dhananjay <pawandhananjay@gmail.com> Co-Authored-By: Jimmy Chen <jchen.tc@gmail.com>
eserilev
pushed a commit
to eserilev/lighthouse
that referenced
this pull request
Oct 30, 2025
Partially addresses sigp#8248 Run the beacon chain, http and network tests only for recent forks instead of everything from phase 0. Also added gloas also to the recent forks list. I thought that would be a good way to know if changes in the current fork affect future forks. Not completely sure if we should run for future forks, but added it so that we can discuss here. Co-Authored-By: Pawan Dhananjay <pawandhananjay@gmail.com> Co-Authored-By: Jimmy Chen <jchen.tc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Partially addresses #8248
Proposed Changes
Run the beacon chain, http and network tests only for recent forks instead of everything from phase 0.
Also added gloas also to the recent forks list. I thought that would be a good way to know if changes in the current fork affect future forks.
Not completely sure if we should run for future forks, but added it so that we can discuss here.