Fix leak in range sync components_by_range_requests
#7767
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
When a data column range sync fails with coupling error returned below, if the coupling error does not contain a column and peer (i.e.
column_and_peer == None
)lighthouse/beacon_node/network/src/sync/block_sidecar_coupling.rs
Lines 286 to 292 in 9181ff4
The entire batch gets retried, without the previous
context.components_by_range_requests
entry being removed, this result in unbounded memory usage increase as shown in the metric:Note: this PR is not tested and I'm not sure if the fix is good - but just wanted to illustrate the issue.