Skip to content

Use SSZ by default when calling /eth/v3/validator/blocks #7727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 23, 2025
Merged

Use SSZ by default when calling /eth/v3/validator/blocks #7727

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b602790
Use ssz as default
chong-he Jul 9, 2025
429884b
simplify
chong-he Jul 14, 2025
9a26794
revert last commit
chong-he Jul 14, 2025
b825482
Merge branch 'v3-validator-block-ssz' of https://github.com/chong-he/…
chong-he Jul 14, 2025
3e4381e
revert
chong-he Jul 14, 2025
4a3c268
simplify
chong-he Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 37 additions & 10 deletions validator_client/validator_services/src/block_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,22 +524,50 @@ impl<S: ValidatorStore + 'static, T: SlotClock + 'static> BlockService<S, T> {
proposer_index: Option<u64>,
builder_boost_factor: Option<u64>,
) -> Result<UnsignedBlock<S::E>, BlockError> {
let (block_response, _) = beacon_node
.get_validator_blocks_v3::<S::E>(
let block_response = match beacon_node
.get_validator_blocks_v3_ssz::<S::E>(
slot,
randao_reveal_ref,
graffiti.as_ref(),
builder_boost_factor,
)
.await
.map_err(|e| {
BlockError::Recoverable(format!(
"Error from beacon node when producing block: {:?}",
e
))
})?;
{
Ok((ssz_block_response, _)) => {
info!(slot = slot.as_u64(), "Received unsigned block in SSZ");
Copy link
Member Author

@chong-he chong-he Jul 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need to log specifically as SSZ (and in JSON), or just leave it as the original log without in SSZ/in JSON, moving this line below and just log it after the match.

Logging in SSZ/JSON provides a bit more info but don't know if it will be helpful? Moving the log after the match and keeping it the same as current is simpler

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind either way, but I think it is redundant because of the warn! explaining the fallback to JSON.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, simplify in 4a3c268 (i.e., use the current info log)


ssz_block_response
}
Err(e) => {
warn!(
slot = slot.as_u64(),
error = %e,
"Beacon node does not support SSZ in block production, falling back to JSON"
Comment on lines +537 to +541
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering is there a way to disable attempting to use SSZ in cases where we know SSZ isn't supported? I don't think it matters too much as the overhead of the API instantly erroring should be quite small, but it's worth considering in cases where the BN -> VC latency is very high

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What we do with the builder is we track the builder's SSZ support and turn it off after the first request fails. I don't think that additional complexity is worth it here however.

);

let (json_block_response, _) = beacon_node
.get_validator_blocks_v3::<S::E>(
slot,
randao_reveal_ref,
graffiti.as_ref(),
builder_boost_factor,
)
.await
.map_err(|e| {
BlockError::Recoverable(format!(
"Error from beacon node when producing block: {:?}",
e
))
})?;

info!(slot = slot.as_u64(), "Received unsigned block in JSON");

// Extract ProduceBlockV3Response (data field of the struct ForkVersionedResponse)
json_block_response.data
}
};

let (block_proposer, unsigned_block) = match block_response.data {
let (block_proposer, unsigned_block) = match block_response {
eth2::types::ProduceBlockV3Response::Full(block) => {
(block.block().proposer_index(), UnsignedBlock::Full(block))
}
Expand All @@ -548,7 +576,6 @@ impl<S: ValidatorStore + 'static, T: SlotClock + 'static> BlockService<S, T> {
}
};

info!(slot = slot.as_u64(), "Received unsigned block");
if proposer_index != Some(block_proposer) {
return Err(BlockError::Recoverable(
"Proposer index does not match block proposer. Beacon chain re-orged".to_string(),
Expand Down