-
Notifications
You must be signed in to change notification settings - Fork 890
Remove KZG verification from local block production and blobs fetched from the EL #7713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove KZG verification from local block production and blobs fetched from the EL #7713
Conversation
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
0d7ea70
to
d7ab88c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting here that we don't really gain anything from kzg verifying blobs returned by the builder when publishing because we have already signed the message by the time we receive the BlobsBundle
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the whole!
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You can check the last failing draft PR here: #7772. You may have to fix your CI before adding the pull request to the queue again. |
Issue Addressed
#7700
Proposed Changes
As described in title, the EL already performs KZG verification on all blobs when they entered the mempool, so it's redundant to perform extra validation on blobs returned from the EL.
This PR removes
This PR does not remove KZG verification on the block publishing path yet.