Refine delayed head block logging #7705
Merged
+31
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
ready-for-review
chong-he
approved these changes
Jul 15, 2025
Comment on lines
-1457
to
-1462
| let block_delays = block_times_cache.get_block_delays( | ||
| head_block_root, | ||
| slot_clock | ||
| .start_of(head_block_slot) | ||
| .unwrap_or_else(|| Duration::from_secs(0)), | ||
| ); |
There was a problem hiding this comment.
Good simplification, because block_delays was already defined above
| @@ -1432,6 +1439,24 @@ fn observe_head_block_delays<E: EthSpec, S: SlotClock>( | |||
| set_as_head_time_ms = format_delay(&block_delays.set_as_head), | |||
| "Delayed head block" | |||
| ); | |||
| if let Some(event_handler) = event_handler { | |||
| if event_handler.has_late_head_subscribers() { | |||
There was a problem hiding this comment.
Nice! Because it is already in the if !block_from_sync{} and now it's put in if late_head{} arm, so the condition becomes simpler
michaelsproul
added
ready-for-merge
|
Thanks for the review @chong-he! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Small tweak to
Delayed head blocklogging to make it more representative of actual issues. Previously we used the total import delay to determine whether a block was late, but this includes the time taken for IO (and now hdiff computation) which happens after the block is made attestable.This PR changes the logic to use the attestable delay (where possible) falling back to the previous value if the block doesn't have one; e.g. if it didn't meet the conditions to make it into the attestable cache.
Additional Info
I've also applied some refactors and simplifications related to the relocation of the
late_headvariable.I got rid of some raw
SystemTimeusage as well, which improves repeatability of test cases by removing realtime variability. In production it should be exactly equivalent.