Skip to content

Beta compiler fixes #5543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2024
Merged

Beta compiler fixes #5543

merged 3 commits into from
Apr 10, 2024

Conversation

@realbigsean
Copy link
Member

Issue Addressed

  • duplicate imports are being flagged in some tests where we use use super::*;
  • there's also a new lint about defining trait bounds in two places, this only affects us in one place

@realbigsean realbigsean added ready-for-review The code is ready for review low-hanging-fruit Easy to resolve, get it before someone else does! labels Apr 9, 2024
@realbigsean
Copy link
Member Author

@Mergifyio queue

@realbigsean realbigsean added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 9, 2024
@mergify
Copy link

mergify bot commented Apr 9, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d527d12

mergify bot added a commit that referenced this pull request Apr 10, 2024
@mergify
Merge of #5543
a2846de
This was referenced Apr 10, 2024
Closed
Merged
Merged
@mergify mergify bot merged commit d527d12 into sigp:unstable Apr 10, 2024
mergify bot added a commit that referenced this pull request Apr 10, 2024
@mergify
Merge of #5543
e2ea777
macladson pushed a commit to macladson/lighthouse that referenced this pull request May 13, 2024
@realbigsean
Beta compiler fixes (sigp#5543)
b786e6d 
* remove duplicate imports in gossip tests. get rid of duplicate trait bound locations

* more double import fixes

* cargo fmt
macladson pushed a commit to macladson/lighthouse that referenced this pull request May 13, 2024
@realbigsean
Beta compiler fixes (sigp#5543)
e7d68a1 
* remove duplicate imports in gossip tests. get rid of duplicate trait bound locations

* more double import fixes

* cargo fmt
macladson pushed a commit to macladson/lighthouse that referenced this pull request May 13, 2024
@realbigsean @macladson
Beta compiler fixes (sigp#5543)
210ff25 
* remove duplicate imports in gossip tests. get rid of duplicate trait bound locations

* more double import fixes

* cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pawanjay176 pawanjay176 pawanjay176 approved these changes

Assignees

No one assigned

Labels

low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@realbigsean @pawanjay176