Skip to content

Conversation

@pahor167
Copy link
Contributor

@pahor167 pahor167 commented Mar 5, 2024

Issue Addressed

#5343

Proposed Changes

When builder_boost_factor is provided with default value, we will skip computation of boosted_relay_value to avoid precision loss and rather return relay_value.

@eserilev
Copy link
Member

eserilev commented Mar 7, 2024

Thanks for the PR! I think it'd be a bit cleaner to make the default value check further up in produce_block_v3. If builder_boost_factor is the default value, we can just pass in None to produce_block_with_verification

@eserilev eserilev added waiting-on-author The reviewer has suggested changes and awaits thier implementation. HTTP-API labels Mar 7, 2024
@pahor167
Copy link
Contributor Author

pahor167 commented Mar 8, 2024

produce_block_with_verification

Thanks for review! PR updated

@eserilev eserilev added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Mar 9, 2024
@dapplion dapplion requested a review from michaelsproul April 3, 2024 02:10
@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Apr 5, 2024
@michaelsproul
Copy link
Member

@Mergifyio queue

@mergify
Copy link

mergify bot commented Apr 5, 2024

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Apr 5, 2024
@jimmygchen
Copy link
Member

@mergify requeue

@mergify
Copy link

mergify bot commented Apr 10, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented Apr 10, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 72af6fb

mergify bot added a commit that referenced this pull request Apr 10, 2024
mergify bot added a commit that referenced this pull request Apr 10, 2024
@mergify mergify bot merged commit 72af6fb into sigp:unstable Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HTTP-API ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants