Report expired sessions #281
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
approved these changes
Apr 2, 2025
looks good that you for resolving this for us so quick 🔥
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users cannot keep track of active sessions as they expire internally in our cache. This PR adds an extra message (breaking the API), that reports when a session has been removed from our internal cache.
This does change the expiry logic also. Previously we were removing elements on most operations, i.e when we send/receive a message. We now only remove old elements when a new session is added, or one fails. So long as there are new connections, we will expire old ones. If the peer set remains consistent without errors, we will no longer expire elements simply based on time. I don't consider this an issue (we can also add this functionality back if anyone is concerned about checking the cache more regularly).