Take filenames with dots into account in get_sigmf_filenames() #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function get_sigmf_filenames() does not work correctly if a file contains dots in the filename. These are interpretted as suffixes by pathlib, and a part of the filename can be removed when forming the different SigMF filenames. This fixes the problem by only considering as file extensions the canonical SigMF file extensions. Any other suffixes are treated as part of the filename and not removed. This fixes sigmf#106.
|
Thanks for working on it @daniestevez. The failing test in the PR I believe is caused by an erroneous Beside that, I think this PR is missing an additional test for this particular circumstance. At minimum it should ensure that |
The get_SigMFFile() method was broken because it used ".sigmf_meta" instead of ".sigmf-meta". This rewrites the method to use get_sigmf_filenames().
This adds a unit test that shows that SigMF files like a.sigmf-meta, b.c.sigmf-meta, and d.e.f.sigmf-meta are all loaded correctly.
|
@Teque5 I've pushed a commit that fixes the failing test and another commit that adds a test case like you described. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function get_sigmf_filenames() does not work correctly if a file contains dots in the filename. These are interpretted as suffixes by pathlib, and a part of the filename can be removed when forming the different SigMF filenames. This fixes the problem by only considering as file extensions the canonical SigMF file extensions. Any other suffixes are treated as part of the filename and not removed.
This fixes #106.