Fix: fixed start sploit for linters #56

kb-nik · 2025-10-16T16:37:30Z

No description provided.

navichok26 · 2025-10-17T07:18:30Z

back/start_sploit.py



-def highlight(text, style=None):
+def highlight(text: str, style: Optional[List[Style]] = None) -> str:


Лучше сделать Optional[List[Style]] -> list[Style] | None, мы используем новый стандарт питона, поэтому так будет красивее, правильно и меньше импортов

navichok26 · 2025-10-17T07:23:05Z

back/start_sploit.py

 from math import ceil
 from urllib.parse import urljoin
 from urllib.request import Request, urlopen
+from typing import List, Optional, Any, Tuple, Dict, Iterator, Set, IO, Mapping


Из импортов нужно 100% убрать List(list), Optional(| None), Tuple(tuple), Dict(dict). Возможно убрать Set(можно заменить на set наверно)

navichok26 · 2025-10-17T07:24:01Z

back/start_sploit.py

 import subprocess
 import time
 import threading
+from re import Pattern


Лучше убрать, до этого импортировали уже re, снизу лучше писать re.Pattern тогда

navichok26 · 2025-10-17T07:32:31Z

back/start_sploit.py



-def check_script_source(source, interpreter):
+def check_script_source(source: str, interpreter: Optional[str]) -> List[str]:


Optional и List

navichok26 · 2025-10-17T07:36:40Z

back/start_sploit.py

            raise APIException(conn.read())

-        return json.loads(conn.read().decode())
+        return json.loads(conn.read().decode())  # type: ignore[no-any-return]


Лучше через isinstance проверить что мы получили dict и дальше с ним работать, если не dict то кидать ошибку, а type: ignore убрать

navichok26 · 2025-10-17T07:36:55Z

back/start_sploit.py



-def post_flags(args, flags):
+def post_flags(args: argparse.Namespace, flags: List[Dict[str, str]]) -> None:


List и Dict

navichok26 · 2025-10-17T07:46:39Z

back/start_sploit.py

-        self._lock = threading.RLock()
+    def __init__(self) -> None:
+        self._flags_seen: Set[str] = set()
+        self._queue: List[Dict[str, str]] = []


List, Dict и Set

navichok26 · 2025-10-17T07:46:59Z

back/start_sploit.py

+        self._lock: threading.RLock = threading.RLock()

-    def add(self, flags, team_name):
+    def add(self, flags: Set[str], team_name: str) -> None:


navichok26 · 2025-10-17T07:47:09Z

back/start_sploit.py

                    self._queue.append({"flag": item, "team": team_name})

-    def pick_flags(self):
+    def pick_flags(self) -> List[Dict[str, str]]:


List и Dict

navichok26 · 2025-10-17T07:47:18Z

back/start_sploit.py



-def display_sploit_output(team_name, output_lines):
+def display_sploit_output(team_name: str, output_lines: List[str]) -> None:


navichok26 · 2025-10-17T07:47:37Z

back/start_sploit.py

+    stream: IO[bytes],
+    args: argparse.Namespace,
+    team_name: str,
+    flag_format: Pattern[str],


navichok26 · 2025-10-17T07:47:54Z

back/start_sploit.py

-        self.instances = {}
+    def __init__(self) -> None:
+        self._counter: int = 0
+        self.instances: Dict[int, subprocess.Popen[bytes]] = {}


navichok26 · 2025-10-17T07:48:17Z

back/start_sploit.py

+    team_name: str,
+    team_addr: Optional[str],
+    attack_no: int,
+    flag_format: Pattern[str],


Optional, Pattern и Tuple

navichok26 · 2025-10-17T07:49:10Z

back/start_sploit.py

+    config: Optional[Dict[str, Any]] = None
+    flag_format: Optional[re.Pattern[str]] = None


Optional и Dict

navichok26 · 2025-10-17T07:49:34Z

back/start_sploit.py


-def show_time_limit_info(args, config, max_runtime, attack_no):
+def show_time_limit_info(
+    args: argparse.Namespace, config: Dict[str, Any], max_runtime: float, attack_no: int


navichok26 · 2025-10-17T07:49:48Z

back/start_sploit.py

+    team_addr: Optional[str],
+    attack_no: int,
+    max_runtime: float,
+    flag_format: Pattern[str],


Optional и Pattern

navichok26 · 2025-10-17T07:55:22Z

back/start_sploit.py

+    args: argparse.Namespace, teams: Dict[str, str], attack_no: int
+) -> Mapping[str, Optional[str]]:


Dict, Optional

Fix: fixed start sploit for linters

e6e1f5d

navichok26 reviewed Oct 17, 2025

View reviewed changes

back/start_sploit.py

stream: IO[bytes],

args: argparse.Namespace,

team_name: str,

flag_format: Pattern[str],

Copy link

Collaborator

navichok26 Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re.Pattern

navichok26 reviewed Oct 17, 2025

View reviewed changes



		def highlight(text, style=None):
		def highlight(text: str, style: Optional[List[Style]] = None) -> str:



		def check_script_source(source, interpreter):
		def check_script_source(source: str, interpreter: Optional[str]) -> List[str]:



		def post_flags(args, flags):
		def post_flags(args: argparse.Namespace, flags: List[Dict[str, str]]) -> None:



		def display_sploit_output(team_name, output_lines):
		def display_sploit_output(team_name: str, output_lines: List[str]) -> None:

		config: Optional[Dict[str, Any]] = None
		flag_format: Optional[re.Pattern[str]] = None

		args: argparse.Namespace, teams: Dict[str, str], attack_no: int
		) -> Mapping[str, Optional[str]]:

Fix: fixed start sploit for linters #56

Are you sure you want to change the base?

Fix: fixed start sploit for linters #56

Uh oh!

Conversation

kb-nik commented Oct 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

navichok26 Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

navichok26 Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

navichok26 Oct 17, 2025 •

edited

Loading

navichok26 Oct 17, 2025 •

edited

Loading