Skip to content

Conversation

kinggoesgaming
Copy link

This removes eslint and its related dependencies and instead installs biome. Also makes fixes to make sure biome does not throw errors.

Lint: npm run lint
Format: npm run format

Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
This currently only suppresses the warning, as the path forward is not clear.

Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
This currently only suppresses the warning, as the path forward is not clear.

Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@shrutikapoor08
Copy link
Owner

Thank you for this PR, Hunar. Why is this necessary, though?

@kinggoesgaming
Copy link
Author

kinggoesgaming commented Jan 23, 2025

Faster, fewer dependencies, included formatter, more lint rules caught (which eslint needs even more deodorant). Plus with biome vscode extension. :)

@kinggoesgaming
Copy link
Author

Don't merge yet... found another issue here but will work on it in the morning

Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@kinggoesgaming
Copy link
Author

now it should be ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants