forked from juliotrigo/sqlalchemy-filters
-
Notifications
You must be signed in to change notification settings - Fork 3
Sqlalchemy 2 support for CI #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under some circunstances, such as prepping an aliased subquery to be joined later on, the model entity is missing, provoking an error when trying to apply filters. (cherry picked from commit edc7c24)
…tyle?) (cherry picked from commit b6791e3)
(cherry picked from commit 203d401)
This property is removed in SQLAlchemy 2.x
… .gitignore This allows Tox to find all Python versions when using pyenv
drop_all() makes the 'bind' positional argument required
Specify compatible versions of SQLAlchemy and SQLAlchemy-Utils for Python, SQLAlchemy versions
Simplifies tox expressions and doesn't change anything fundamental about this library. 0.38.3 dropped support for Python 3.4 and 3.5 which sqlalchemy-filters never supported in the first place
CI back to working in the upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this so I can run my own GH actions to make sure they succeed instead of waiting for approval in the parent repo.