Table aliases might not be resolved when SubselectFromClause is being processed and wrong alias is generated #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paranoiq
force-pushed
the
vn-fix-subqueries
branch
from
9c24a45 to
14f8ba1
Compare
|
I believe we can now remove the second DQL parsing resulting in |
…er is called and wrong alias is generated)
paranoiq
force-pushed
the
vn-fix-subqueries
branch
from
14f8ba1 to
b0ac665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UseIndexHintHandler registers listening for FromClause and SubselectFromClause. when hint is intended for main FROM and the handler is called with the subselect, the table aliases for the whole query might not be resolved (depends also on columns in SELECT clause) and SqlWalker generates wrong alias. the handler then fails to find and replace that clause ("LogicException: Invalid hint for index IDX_WAREHOUSE_PRODUCT__EMPTY, table occurrence with DQL alias occ is not present in the query.")
probable cause is that Doctrine changed order of processing things. otherwise i have no idea how it could have ever worked
aliases should either be resolved before processing index hints or they should be independent of order