🐛 Wrong error when submitting presence during hard rollback. #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawidreedsy
commented
Mar 6, 2025
| }; | ||
|
|
||
| var error = null; | ||
| if(this._doc._isInHardRollback) { |
There was a problem hiding this comment.
I decided to not change _isInHardRollback to isInHardRollback as i think it should not be used out side of lib. Feels a bit code smell TBH. I am open for suggesstions.
Suggested change
| if(this._doc._isInHardRollback) { | |
| if(this._doc.isInHardRollback) { |
Similar case to: - #692 however instead of submitting ops to doc is when we submit doc presence
dawidreedsy
force-pushed
the
bug-fix/broken-presence-hardrollback
branch
from
0454722 to
0b16633
Compare
dawidreedsy
changed the title
alecgibson
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar case to:
however instead of submitting ops to doc is when we submit doc presence