Fix chat endpoint #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced '/ask' with '/api/v1/chats' to align with updated API specifications. This ensures compatibility with the latest backend changes and avoids potential request failures.
Added support for extracting and handling `X-Chat-Uuid` from API response headers. Updated `ChatService` to pass chat UUID to a callback, and `ChatContainer` to set it when not already defined. Enhanced `APIClient` to merge custom headers and enforce CORS mode.
This commit introduces unit tests for the ChatService API client, including both streaming and synchronous message handling. The tests verify proper callback handling, chat UUID extraction, and payload processing. Mocking is used to simulate service behavior effectively.
Added comprehensive tests to cover streaming, chat history, UUID handling, and error scenarios. Refactored mocks to simulate more realistic behaviors and ensure clarity. This improves the reliability and robustness of ChatService unit tests.
The file `api-client.test.ts` containing tests for the ChatService API client has been removed, likely as part of codebase cleanup or migration efforts. These tests are no longer necessary and have been entirely deleted to maintain a leaner codebase.
Replaced "X-Chat-Uuid" with "X-MKit-Chat-UUID" for consistency with updated API response headers. Removed redundant lowercase header check and related console logs to streamline the code.
|
Related backend changes are here #23 |
|
This was a fix for shaharia-lab/mcp-kit#19 this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several improvements and new features for the chat functionality in the
ChatContainercomponent and related services. The most important changes include adding support for handlingchatUuidin the payload and response headers, and updating the API endpoints.Enhancements to
ChatContainercomponent:src/components/ChatContainer/ChatContainer.tsx: Added support for includingchatUuidin the payload if available and settingchatUuidfrom response headers if not already set. [1] [2]Updates to
APIClientandChatService:src/services/APIClient.ts: Modified thefetchmethod to merge custom headers with default headers and enabled CORS mode.src/services/ChatService.ts: Updated thesendMessagemethod to use the new API endpoint/api/v1/chats.src/services/ChatService.ts: Enhanced thesendStreamMessagemethod to handlechatUuidfrom response headers and added debug logging for all response headers.