Add CI check for SPIRV-Tools generated files consistency #8510
+211
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwak-work
force-pushed
the
ci/protect-spirv-generated
branch
from
cb9f321 to
9ffd551
Compare
|
🌈 Formatted, please merge the changes from this PR |
- Validates external/spirv-tools-generated matches current spirv-tools build - Only runs when external/spirv-tools or external/spirv-headers are modified - Checks spirv-headers commit consistency with spirv-tools DEPS - Provides clear error messages and fix instructions
jkwak-work
force-pushed
the
ci/protect-spirv-generated
branch
from
1ab29c1 to
d4376bc
Compare
|
thanks, this really helps with the maintainer duty. |
gtong-nv
reviewed
Sep 23, 2025
| platform: x86_64 | ||
| config: release | ||
| runs-on: '["Windows", "self-hosted", "GCP-T4"]' | ||
|
|
There was a problem hiding this comment.
Do we really need to run this in each CL? I feel like this should be only needed when we try to upgrade the spirv-tools?
|
I think this workflow can be an indenpendent one that we can manually dispatch, just like |
TLDR: Restructured workflow to prevent check-ci from hanging when no SPIRV files are modified Flow Overview: 1. check-spirv-changes: Always runs, detects if external/spirv-tools* files were modified 2. check-spirv-consistency: Conditionally runs only when SPIRV files are modified (job-level conditional) 3. spirv-check-summary: Always runs with clear success/failure reporting Key Fixes: - Removed invalid workflow parameters that caused CI syntax errors - Split single job into three jobs with proper dependency handling - Added external/spirv-tools-generated to change detection - Summary job uses if: always() and handles skipped dependencies correctly - Provides definitive status for check-ci dependency resolution This prevents the "pending" state that occurred when only YAML files or non-SPIRV files were modified.
|
I pushed a second commit to resolve the stuck problem at "check-ci". @gtong-nv , the checking will be skipped when there is no changes in |
|
🌈 Formatted, please merge the changes from this PR |
|
There is an issue parsing the workflow file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8509