Add default feature for JIT #589
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdm
approved these changes
Jul 7, 2025
jschwe
force-pushed
the
flag_disable_jit2
branch
from
19b4bd4 to
1d4f3f0
Compare
When building servo on Linux with the profile `production-stripped`, disabling JIT with this change shaves off 9MiB from the servo binary size, which is around 10%. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
force-pushed
the
flag_disable_jit2
branch
from
1d4f3f0 to
86b5a64
Compare
jdm
reviewed
Jul 10, 2025
| @@ -12,6 +12,7 @@ doctest = false | |||
|
|
|||
| [features] | |||
| debugmozjs = ['mozjs_sys/debugmozjs'] | |||
| jit = ['mozjs_sys/jit'] | |||
There was a problem hiding this comment.
This should be a default feature for the mozjs crate as well.
There was a problem hiding this comment.
I moved the default feature to mozjs and removed it as default feature from mozjs_sys. Otherwise we couldn't disable it, unless mozjs would depend on monz_js_sys with default-features = false. Since I don't think there would be any other users of the sys crate, besides mozjs, I think it makes the most sense to expose the jit feature as default in mozjs and don't add any default features to mozjs_sys.
What do you think?
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revival of #523 - but with a slightly different background.
When building servo on Linux with the profile
production-stripped, disabling JIT with this change shaves off 9MiB from the servo binary size, which is around 10% (80MiB vs. 89MiB).