Fix #213 - Review DataInputSchema unmarshal function; review k8s annotations for Object type #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n; review k8s annotations for Object type Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
|
@ribeiromiranda can u please take a look? |
spolti
reviewed
Oct 11, 2024
| @@ -0,0 +1,53 @@ | |||
| # Copyright 2024 The Serverless Workflow Specification Authors | |||
There was a problem hiding this comment.
Yes, it is the new test case. There's a test case in which we go through each file in this folder and perform a parse.
spolti
reviewed
Oct 11, 2024
| @@ -581,17 +581,6 @@ func TestFromFile(t *testing.T) { | |||
| assert.Equal(t, "SendTextForHighPriority", w.States[10].SwitchState.DefaultCondition.Transition.NextState) | |||
| assert.Equal(t, true, w.States[10].End.Terminate) | |||
| }, | |||
| }, { | |||
| "./testdata/workflows/dataInputSchemaValidation.yaml", func(t *testing.T, w *model.Workflow) { | |||
| assert.NotNil(t, w.DataInputSchema) | |||
There was a problem hiding this comment.
No this validation is not valid anymore since Schema is not loading the external file to the attribute.
spolti
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
minor comments.
@ribeiromiranda do you want to take another look before merging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Fix #213
Special notes for reviewers:
I also added the following annotations:
To
MetadataandObjectattributes since we can't force the type object on Kubernetes context for this type. For example, in the schema use case, theDataInputSchemacan be a string.Additional information (if needed):