Skip to content

Conversation

serpro69
Copy link
Owner

@serpro69 serpro69 commented Aug 27, 2025

TODO

  • test publishing
  • cleanup buildSrc plugins
    • there's likely some dependencies that are duplicated which were there due to usage of shadow plugin
    • look over other stuff and clean it up
  • update workflows
    • mvp: build and test from pr and merges to master; good-to-have: publishing snapshots from merges to master
  • fix docs
    • snippets are broken

@serpro69 serpro69 force-pushed the kmp branch 2 times, most recently from 4b0f38f to 6ecfdc3 Compare August 27, 2025 18:02
@serpro69 serpro69 changed the title Kmp Refactor build configs to use kotlin multiplatform plugin Aug 28, 2025
@serpro69 serpro69 marked this pull request as ready for review August 28, 2025 14:00
@serpro69

This comment was marked as resolved.

@serpro69 serpro69 marked this pull request as draft September 4, 2025 15:20
@serpro69 serpro69 force-pushed the kmp branch 7 times, most recently from 9c8047d to 5cb9fa3 Compare September 12, 2025 11:33
Prepare for refactoring to use kotlin multiplatform plugin.
Shadow isn't really supported by kmp, and I really don't want to add any
workarounds to make it work for jvm sources, so just killing it off.
Remove all integration test logic from build.gradl.kts files
to further simplify build configs for kmp refactoring
Makes it easier to publish with consistent artifact names but w/o the need to modify
the entire directory structure of the project
Use versioning plugin to determine if current build
is a release or not, instead of relying on the
outcome of 'tag' tasks. This makes things more reliable.
@serpro69 serpro69 added breaking 💔 Indicates a breaking change enhancement 🚀 New feature or request core 🧬 Issue related to :core module labels Sep 13, 2025
@serpro69 serpro69 requested a review from Copilot September 13, 2025 14:43
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the build configurations to use the Kotlin Multiplatform plugin instead of the previous shadow jar approach. The changes modernize the build system, remove outdated dependencies, and consolidate build logic.

  • Migrates from the shadow plugin approach to Kotlin Multiplatform plugin with proper source sets
  • Updates build conventions and publishing configurations to support the new multiplatform structure
  • Consolidates test execution and removes separate integration test tasks

Reviewed Changes

Copilot reviewed 37 out of 1267 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
core/build.gradle.kts Migrates to Kotlin multiplatform with jvmMain/jvmTest source sets, removes shadow configuration
buildSrc/src/main/kotlin/*.gradle.kts Updates build conventions to use multiplatform structure and modern publishing
cli-bot/build.gradle.kts Updates dependencies and task configurations for new multiplatform setup
buildSrc/src/main/kotlin/utils/* Adds new utility classes for build configuration and publishing
.github/workflows/* Updates CI workflows to use new test commands and remove integration test tasks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking 💔 Indicates a breaking change core 🧬 Issue related to :core module enhancement 🚀 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant