-
-
Notifications
You must be signed in to change notification settings - Fork 46
Refactor build configs to use kotlin multiplatform plugin #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
4b0f38f
to
6ecfdc3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
9c8047d
to
5cb9fa3
Compare
Prepare for refactoring to use kotlin multiplatform plugin. Shadow isn't really supported by kmp, and I really don't want to add any workarounds to make it work for jvm sources, so just killing it off.
Remove all integration test logic from build.gradl.kts files to further simplify build configs for kmp refactoring
Makes it easier to publish with consistent artifact names but w/o the need to modify the entire directory structure of the project
Use versioning plugin to determine if current build is a release or not, instead of relying on the outcome of 'tag' tasks. This makes things more reliable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the build configurations to use the Kotlin Multiplatform plugin instead of the previous shadow jar approach. The changes modernize the build system, remove outdated dependencies, and consolidate build logic.
- Migrates from the shadow plugin approach to Kotlin Multiplatform plugin with proper source sets
- Updates build conventions and publishing configurations to support the new multiplatform structure
- Consolidates test execution and removes separate integration test tasks
Reviewed Changes
Copilot reviewed 37 out of 1267 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
core/build.gradle.kts | Migrates to Kotlin multiplatform with jvmMain/jvmTest source sets, removes shadow configuration |
buildSrc/src/main/kotlin/*.gradle.kts | Updates build conventions to use multiplatform structure and modern publishing |
cli-bot/build.gradle.kts | Updates dependencies and task configurations for new multiplatform setup |
buildSrc/src/main/kotlin/utils/* | Adds new utility classes for build configuration and publishing |
.github/workflows/* | Updates CI workflows to use new test commands and remove integration test tasks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
TODO