Fix ping_reset bad check
#354
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an RTMP connection become stall (no more IO), the `ngx_rmtp_ping` send a ping request to the client, but during this sending the `ping_reset` flag is set to 1 in `ngx_rtmp_send` (because of [1]) preventing the detection of a not responding connection because in `ngx_rmtp_ping()` the `ping_reset` check will then reset the ping instead of finalizing the session. This patch ensure that `ping_reset` is not set to 1 in both `ngx_rtmp_recv()` and `ngx_rtmp_send()` when a PING test is ongoing `ping_active = 1` [1] sergey-dryabzhinsky@345a00f
|
This PR shall fix #353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an RTMP connection become stall (no more IO), the
ngx_rmtp_pingsend a ping request to the client, but during this sending theping_resetflag is set to 1 inngx_rtmp_send(because of [1]) preventing the detection of a not responding connection because inngx_rmtp_ping()theping_resetcheck will then reset the ping instead of finalizing the session.This patch ensure that
ping_resetis not set to 1 in bothngx_rtmp_recv()andngx_rtmp_send()when a PING test is ongoingping_active = 1[1] 345a00f