remove unnecessary link with libxkbswitch

[thechampagne]

No description provided.

[sergei-mironov]

Hi @thechampagne . Thank you for the suggestion. Without your change, we keep binary code in the library and call it form the main application. You are suggesting to remove the linkage complexity at the price of duplicating the binary. Could you please describe the motivation behind this change? Do you have any problems with the linkage?

[thechampagne]

we keep binary code in the library and call it form the main application.

Hi, I noticed that the executable is linked with libxkbswitch. I read the source code but couldn't find where it is actually called, so I thought it might be a mistaken link. Could you clarify where it is being called?

[sergei-mironov]

we keep binary code in the library and call it form the main application.

Hi, I noticed that the executable is linked with libxkbswitch. I read the source code but couldn't find where it is actually called, so I thought it might be a mistaken link. Could you clarify where it is being called?

The original version treats src/XKeyboard.cpp as a part of the library rather than of the main executable. Thus, every call to an entity defined in this file is actually a call to the library.

[thechampagne]

I see. I prefer duplicating small code to minimize moving parts as much as possible. However, I understand that the library could be useful for other applications, like Vim. I can always specify BUILD_XKBSWITCH_LIB=OFF. Thank you! 👍