Replace declarative macros for generating argument parsers #360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the declarative macros
parse_prefix_args!
andparse_slash_args!
that poise'scommand
proc macro was deferring to in order to generate its argument parsing logic. Their functionality is now directly incorporated into the proc macro, which should make things much more readable and maintainable, and open the door for added features down the line. For example, the following changes are now much easier to add support for:#[string] Option<T>
and#[string] Vec<T>
, which should bring#[string]
parameters to full parity with standard parameters afterPopArgument
specialization was removed.#[lazy] Vec<T>
#[lazy] #[string] Option<T>