add f16 and f128 support #2941
Open
add f16 and f128 support #2941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mingun
reviewed
Jun 19, 2025
Mingun
reviewed
Jun 21, 2025
serde/src/de/mod.rs
Outdated
| @@ -1439,6 +1463,17 @@ pub trait Visitor<'de>: Sized { | |||
| )) | |||
| } | |||
|
|
|||
| /// The input contains a `f16`. | |||
| /// | |||
| /// The default implementation forwards to visit_f64. | |||
There was a problem hiding this comment.
Like the others:
Suggested change
| /// The default implementation forwards to visit_f64. | |
| /// The default implementation forwards to [`visit_f64`]. |
There was a problem hiding this comment.
this break documentation build sadly
There was a problem hiding this comment.
You'll need to add something like:
[`visit_f64`]: #method.visit_f64at the bottom of the doc comment.
There was a problem hiding this comment.
Very strange, that documentation is broken, it should be broken in other places as well. The correct link should be
[`visit_f64`](Self::visit_f64)
There was a problem hiding this comment.
I think either way should work. You can see that it does link correctly on docs.rs for the other links for this trait. For example: https://docs.rs/serde/latest/serde/de/trait.Visitor.html#method.visit_u64
There was a problem hiding this comment.
Of course, just intralinks can be checked by the compiler
Mingun
reviewed
Jun 21, 2025
Co-authored-by: Mingun <Alexander_Sergey@mail.ru>
Co-authored-by: Mingun <Alexander_Sergey@mail.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add initial support for f16 and f128, next steps are to add this support in serde_test if this lands
helps with adding ecosystem support par in rust-lang/rust#116909