Remove actually_private::T
#2939
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As posted by @oli-obk in #2608 (comment), this PR removes
actually_private::T
type from signature of the hiddenDeserializer::__deserialize_content
method, likeVisitor::__private_visit_untagged_option
does not have such guard:serde/serde/src/de/mod.rs
Lines 1679 to 1687 in 2130ba5
This guard just makes life harder in some cases without real benefits. If you use private API you already understand consequences and them can be totally acceptable, especially if you depend on the specific version