Skip to content

feat(typescript): update and add SEMGREP_EXPRESSION entry point #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

brandonspark
Copy link
Contributor

@brandonspark brandonspark commented May 8, 2025

I'm trying to make it so that we can use the tree-sitter-typescript parser for pattern parsing. To do this, I need to add an entry point for parsing common Typescript patterns.

Importantly, the latest versions of tree-sitter-typescript assume a testing infra structure that is only compatible with the latest versions of tree-sitter-cli. This means that although the check will probably be green, the tree-sitter combined grammar testing infrastructure does not work right now, it cannot find the tree-sitter-typescript testing suite. Fixing this requires upgrading to a more recent version of tree-sitter-cli, which is a large change.

I'd prefer to move forward with this change, since tests for test-language-typescript were failing before this PR anyways, and we do have some e2e tests that we can rely on.

Checklist

  • Any new parsing code was already published, integrated, and merged into Semgrep. DO NOT MERGE THIS PR BEFORE THE SEMGREP INTEGRATION WORK WAS COMPLETED.
  • Change has no security implications (otherwise, ping the security team)

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@brandonspark brandonspark changed the title update typescript feat(typescript): May 8, 2025
@brandonspark brandonspark changed the title feat(typescript): feat(typescript): update and add SEMGREP_EXPRESSION entry point May 8, 2025
@brandonspark brandonspark marked this pull request as ready for review May 8, 2025 00:38
@brandonspark brandonspark requested a review from a team as a code owner May 8, 2025 00:38
@brandonspark brandonspark requested a review from amchiclet May 8, 2025 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants