Skip to content

update tree-sitter-kotlin #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jespera
Copy link

@jespera jespera commented Apr 29, 2025

Checklist

  • Any new parsing code was already published, integrated, and merged into Semgrep. DO NOT MERGE THIS PR BEFORE THE SEMGREP INTEGRATION WORK WAS COMPLETED.
  • Change has no security implications (otherwise, ping the security team)

@jespera jespera requested a review from a team as a code owner April 29, 2025 19:57
@jespera jespera requested a review from ihji April 29, 2025 19:57
@CLAassistant
Copy link

CLAassistant commented Apr 29, 2025

CLA assistant check
All committers have signed the CLA.

@jespera jespera force-pushed the kotlin-trailing-comma-type-params branch from 87c1b83 to e8df338 Compare April 29, 2025 20:05
@yosefAlsuhaibani
Copy link
Contributor

Thank you for contributing! To get semgrep to use this parser, you'll need to make a PR in semgrep/semgrep that:

  1. Bumps the kotlin tree-sitter submodule (i.e this submodule https://github.com/semgrep/semgrep/tree/develop/languages/kotlin/tree-sitter)
  2. Updates the tree-sitter CST -> Ast_generic translation (here: https://github.com/semgrep/semgrep/blob/develop/languages/kotlin/generic/Parse_kotlin_tree_sitter.ml)
    Feel free to request my comment in the semgrep/semgrep repo.

@jespera
Copy link
Author

jespera commented May 1, 2025

Thank you for contributing! To get semgrep to use this parser, you'll need to make a PR in semgrep/semgrep that:

1. Bumps the kotlin tree-sitter submodule (i.e this submodule https://github.com/semgrep/semgrep/tree/develop/languages/kotlin/tree-sitter)

2. Updates the tree-sitter CST -> Ast_generic translation (here: https://github.com/semgrep/semgrep/blob/develop/languages/kotlin/generic/Parse_kotlin_tree_sitter.ml)
   Feel free to request my comment in the semgrep/semgrep repo.

@yosefAlsuhaibani To make a PR in semgrep/semgrep where I update the submodule, don't I first need to have these changes merged so that there's a new commit-sha to update the submodule to?

@yosefAlsuhaibani
Copy link
Contributor

@jespera You're totally right that I did forget a step: I've released/updated the semgrep-kotlin to reflect your changes (see: semgrep/semgrep-kotlin@9801f75); we usually wait merging the ocaml-tree-sitter-semgrep PR until the subsequent semgrep/semgrep work is done.

Copy link
Contributor

yosefAlsuhaibani commented May 3, 2025

Merge activity

  • May 3, 10:09 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • May 3, 10:09 AM EDT: Graphite couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants