Skip to content

Added a warning log level. #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2025
Merged

Conversation

Dimi1010
Copy link
Collaborator

Split of #1845

This PR adds a Warn log level that sits between ERROR and INFO and can be used to signalize non-critical issues in the runtime.

@Dimi1010 Dimi1010 marked this pull request as ready for review July 11, 2025 09:49
@Dimi1010 Dimi1010 requested a review from seladb as a code owner July 11, 2025 09:49
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.21%. Comparing base (824ea14) to head (0752652).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff            @@
##              dev    #1872    +/-   ##
========================================
  Coverage   83.21%   83.21%            
========================================
  Files         285      285            
  Lines       49826    49835     +9     
  Branches    10798    10551   -247     
========================================
+ Hits        41462    41472    +10     
- Misses       7194     7202     +8     
+ Partials     1170     1161     -9     
Flag Coverage Δ
alpine320 75.49% <100.00%> (+0.01%) ⬆️
fedora42 75.55% <100.00%> (-0.03%) ⬇️
macos-13 80.70% <100.00%> (+<0.01%) ⬆️
macos-14 80.70% <100.00%> (+<0.01%) ⬆️
macos-15 80.69% <100.00%> (+<0.01%) ⬆️
mingw32 70.22% <ø> (-0.04%) ⬇️
mingw64 70.21% <ø> (-0.04%) ⬇️
npcap 85.12% <ø> (-0.02%) ⬇️
rhel94 75.35% <100.00%> (-0.04%) ⬇️
ubuntu2004 59.20% <100.00%> (+0.02%) ⬆️
ubuntu2004-zstd 59.31% <100.00%> (+<0.01%) ⬆️
ubuntu2204 75.30% <100.00%> (+<0.01%) ⬆️
ubuntu2204-icpx 61.57% <ø> (+0.04%) ⬆️
ubuntu2404 75.53% <100.00%> (+<0.01%) ⬆️
ubuntu2404-arm64 75.52% <100.00%> (+<0.01%) ⬆️
unittest 83.21% <100.00%> (+<0.01%) ⬆️
windows-2022 85.10% <ø> (-0.02%) ⬇️
windows-2025 85.16% <ø> (-0.01%) ⬇️
winpcap 85.28% <ø> (ø)
xdp 51.39% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@tigercosmos tigercosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dimi1010 Dimi1010 merged commit ed08e08 into seladb:dev Jul 12, 2025
42 checks passed
@Dimi1010 Dimi1010 deleted the feature/warn-log-level branch July 12, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants