Skip to content

Analytics.js cleanup (part 1) #7653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 5, 2025
Merged

Analytics.js cleanup (part 1) #7653

merged 13 commits into from
Jun 5, 2025

Conversation

rchinn1
Copy link
Contributor

@rchinn1 rchinn1 commented May 30, 2025 •
edited
Loading

Proposed changes

Part 1 of some Analytics.js section updates/cleanup:

  • Fixed several tables in the Analytics.js source doc that were formatted inconsistently
  • Closed a code sample that carried over into the section below
  • Fixed casing of the Segment methods
  • Added a clarifying statement about using Segment.io=true in the parameters object of a Load call
  • Other general cleanup to align these docs with our style guide

Merge timing

  • No rush, once approved

Related issues (optional)

Addresses https://twilio-engineering.atlassian.net/browse/DOC-1121 and #7655

@rchinn1 rchinn1 added the fixed-content fix to content that has outdated or wrong information label May 30, 2025
@netlify Netlify
Copy link

netlify bot commented May 30, 2025

✅ Deploy Preview for segment-docs ready!

Name Link
🔨 Latest commit 005cde1
🔍 Latest deploy log https://app.netlify.com/projects/segment-docs/deploys/683a222f5960b000086f205a
😎 Deploy Preview https://deploy-preview-7653--segment-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rchinn1 rchinn1 changed the title Analytics.js cleanup Analytics.js cleanup (part 1) Jun 3, 2025
@rchinn1 rchinn1 marked this pull request as ready for review June 3, 2025 22:40
@rchinn1 rchinn1 requested a review from a team as a code owner June 3, 2025 22:40
@rchinn1 rchinn1 requested a review from forstisabella June 3, 2025 22:40
forstisabella
forstisabella previously approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@forstisabella forstisabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥 great work, Ryan!!

@rchinn1 @forstisabella
Update src/connections/sources/catalog/libraries/website/javascript/i…
2af094c 
…ndex.md

Co-authored-by: forstisabella <92472883+forstisabella@users.noreply.github.com>
@rchinn1 rchinn1 requested a review from forstisabella June 5, 2025 16:32
@rchinn1
Copy link
Contributor Author

rchinn1 commented Jun 5, 2025

Thanks for the review, @forstisabella! Looks like I need another ✅ from you when you get a moment.

@rchinn1 rchinn1 merged commit 198d600 into develop Jun 5, 2025
4 checks passed
@rchinn1 rchinn1 deleted the Analytics.js-edits branch June 5, 2025 17:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

Thank you for your contribution! Your pull request is merged, but may take a day or two to appear on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forstisabella forstisabella forstisabella approved these changes

Assignees
No one assigned
Labels
fixed-content fix to content that has outdated or wrong information
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rchinn1 @forstisabella @stayseesong