Add method to fetch messages in batch #1390
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krsoninikhil
force-pushed
the
feat/fetch-batch
branch
from
b770811 to
9938849
Compare
krsoninikhil
force-pushed
the
feat/fetch-batch
branch
from
9938849 to
1db836a
Compare
krsoninikhil
commented
Jun 8, 2025
krsoninikhil
commented
Jun 8, 2025
| i++ | ||
| } | ||
| return msgBatch, nil | ||
| } |
There was a problem hiding this comment.
Duplication of the code can be avoided by calling this method in FetchMessage. I'll refactor if once the approach gets reviewed.
There was a problem hiding this comment.
What happens if the number of messages doesn't reach the desired batchSize?
you changed the offset when the batch is processed, what happens if one of the messages in the batch fails? Is there any mechanism in place to handle that? Do you have any ideas for a fallback strategy for this?!
There was a problem hiding this comment.
@ghaninia for batch processing possible use manuall ack, maybe?
If one of message failed, we can ack all messages before failed, except message with problem.
Since FetchMessage is already reading messages from a fetched batch, this new method just hold the messages util the batchSize number of messages are read. Fixes segmentio#123
krsoninikhil
force-pushed
the
feat/fetch-batch
branch
from
1db836a to
17cc32f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since FetchMessage is already reading messages from a fetched batch, this new method just hold the messages util the batchSize number of messages are read.
Fixes #123