Skip to content

feat: πŸ§‘β€πŸ’» add recipe add-function #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

signekb
Copy link
Member

@signekb signekb commented Sep 12, 2024

Description

I'm not sure that this is the best way to go about it - and as we, @lwjohnst86 , talked about we might want to make a tool for tasks like this at some point. But maybe this is fine for now?

At least I find this helpful - instead of having to create the function file and corresponding test file by hand.

With this, the command just add-function sprout core hello creates sprout/core/hello.py and the corresponding test file tests/core/test_hello.py

Reviewer Focus

This PR needs a quick review.

## Description 

I'm not sure that this is the best way to go about it - and as we, @lwjohnst86 , talked about we might want to make a tool for tasks like this at some point. But maybe this is fine for now? 

At least I find this helpful - instead of having to create the function file and corresponding test file by hand.
@signekb
Copy link
Member Author

signekb commented Sep 12, 2024

What do you think, @martonvago ? Would you find this helpful?

@lwjohnst86 lwjohnst86 changed the title feat: add recipe add-function feat: add recipe add-function Sep 12, 2024
@lwjohnst86 lwjohnst86 changed the title feat: add recipe add-function feat: πŸ§‘β€πŸ’» add recipe add-function Sep 12, 2024
Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely like the idea. And putting it in here for now is a good starting point, until we can think about how we might want to build tools for automating/streamlining our own work.

Copy link
Contributor

@martonvago martonvago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this too!! πŸš€

@signekb signekb merged commit 7d5b04a into main Sep 13, 2024
1 check passed
@signekb signekb deleted the feat/add-just-recipe-add-function branch September 13, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants