Skip to content

refactor: ♻️ tweak copier settings #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 23, 2025
Merged

refactor: ♻️ tweak copier settings #91

merged 12 commits into from
Jul 23, 2025

Conversation

martonvago
Copy link
Contributor

@martonvago martonvago commented Jul 17, 2025

Description

This PR tweaks some copier settings.

Closes #47 closes #46

This PR needs a quick review.

Checklist

  • Formatted Markdown
  • Ran just run-all

@martonvago martonvago moved this from Todo to In Review in Iteration planning Jul 17, 2025
@martonvago martonvago marked this pull request as ready for review July 17, 2025 15:52
@martonvago martonvago requested a review from a team as a code owner July 17, 2025 15:52
copier.yaml Outdated
Comment on lines 32 to 34
board_number:
type: int
help: "What is the number of the GitHub project board to add issues and PRs to?"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a dummy value / default in case someone doesn't have a project board?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just empty or none 👍

Copy link
Member

@lwjohnst86 lwjohnst86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Only some small comments ☺️

copier.yaml Outdated
Comment on lines 32 to 34
board_number:
type: int
help: "What is the number of the GitHub project board to add issues and PRs to?"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just empty or none 👍

copier.yaml Outdated
default: >-
{{ "@%s/developers" % package_github_repo.split('/')[0] if package_github_repo else "" }}

board_number:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
board_number:
github_board_number:

Just to be clearer that it is from GitHub.

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Jul 23, 2025
@martonvago martonvago requested a review from lwjohnst86 July 23, 2025 09:44
@martonvago martonvago moved this from In Progress to In Review in Iteration planning Jul 23, 2025
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too confident about reviewing the exact details of this, but it looks good to me. Looking forward to using it! 🌟

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Jul 23, 2025
@lwjohnst86 lwjohnst86 merged commit e0c85ef into main Jul 23, 2025
5 checks passed
@lwjohnst86 lwjohnst86 deleted the refactor/copier branch July 23, 2025 10:16
@github-project-automation github-project-automation bot moved this from In Progress to Done in Iteration planning Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add variables to copier.yml List all variables to extract
3 participants