-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: ♻️ tweak copier settings #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
copier.yaml
Outdated
board_number: | ||
type: int | ||
help: "What is the number of the GitHub project board to add issues and PRs to?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have a dummy value / default in case someone doesn't have a project board?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just empty or none 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Only some small comments
copier.yaml
Outdated
board_number: | ||
type: int | ||
help: "What is the number of the GitHub project board to add issues and PRs to?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, just empty or none 👍
copier.yaml
Outdated
default: >- | ||
{{ "@%s/developers" % package_github_repo.split('/')[0] if package_github_repo else "" }} | ||
|
||
board_number: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
board_number: | |
github_board_number: |
Just to be clearer that it is from GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too confident about reviewing the exact details of this, but it looks good to me. Looking forward to using it! 🌟
Description
This PR tweaks some copier settings.
Closes #47 closes #46
This PR needs a quick review.
Checklist
just run-all