Skip to content

feat: ✨ add Commitizen version bump with GitHub workflow #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 15, 2025

Conversation

lwjohnst86
Copy link
Member

Description

Adding auto-version update workflow via Commitizen. Right now though, I don't know if the version_files will work though, since it is basic "search and replace for version number in the given files". The datapackage.json file will/may have two version fields, one in the top level and another in the sources level. So this might also bump those versions too (like we had an issue with in Sprout). So we'll have to see how it goes.

Closes #51
Closes #55

This PR needs a quick review.

@lwjohnst86 lwjohnst86 moved this from Todo to In Review in Iteration planning Jul 14, 2025
signekb
signekb previously approved these changes Jul 15, 2025
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Let's see how it goes 🤞

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Jul 15, 2025
@lwjohnst86 lwjohnst86 requested a review from signekb July 15, 2025 12:50
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Iteration planning Jul 15, 2025
Copy link
Member

@signekb signekb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mini suggestions ✏️

@github-project-automation github-project-automation bot moved this from In Review to In Progress in Iteration planning Jul 15, 2025
@signekb
Copy link
Member

signekb commented Jul 15, 2025

Unrelated to the changes here, the test check fails ⬆️

@lwjohnst86
Copy link
Member Author

Yea, I'm trying to fix it 🤔

lwjohnst86 and others added 2 commits July 15, 2025 15:47
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
@lwjohnst86 lwjohnst86 requested a review from signekb July 15, 2025 13:48
@lwjohnst86 lwjohnst86 moved this from In Progress to In Review in Iteration planning Jul 15, 2025
@lwjohnst86 lwjohnst86 enabled auto-merge (squash) July 15, 2025 13:53
@lwjohnst86 lwjohnst86 merged commit e02f93e into main Jul 15, 2025
5 checks passed
@lwjohnst86 lwjohnst86 deleted the feat/add-release-workflow branch July 15, 2025 13:55
@github-project-automation github-project-automation bot moved this from In Review to Done in Iteration planning Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Use commitizen to do version updating? Include commitizen in the template to auto-release the generated template
2 participants