generated from seedcase-project/template-python-package
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: ✨ add Commitizen version bump with GitHub workflow #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signekb
previously approved these changes
Jul 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) Let's see how it goes 🤞
…ata-package into feat/add-release-workflow
signekb
reviewed
Jul 15, 2025
…ata-package into feat/add-release-workflow
signekb
requested changes
Jul 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mini suggestions ✏️
Unrelated to the changes here, the test check fails ⬆️ |
Yea, I'm trying to fix it 🤔 |
Co-authored-by: Signe Kirk Brødbæk <40836345+signekb@users.noreply.github.com>
signekb
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding auto-version update workflow via Commitizen. Right now though, I don't know if the
version_files
will work though, since it is basic "search and replace for version number in the given files". Thedatapackage.json
file will/may have twoversion
fields, one in the top level and another in thesources
level. So this might also bump those versions too (like we had an issue with in Sprout). So we'll have to see how it goes.Closes #51
Closes #55
This PR needs a quick review.