-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add mandatory test 6.1.27.18 #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
domachine
wants to merge
1
commit into
main
Choose a base branch
from
325-mandatory-test-6.1.27.18
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
import Ajv from 'ajv/dist/jtd.js' | ||
import bcp47 from 'bcp47' | ||
|
||
const ajv = new Ajv() | ||
|
||
/* | ||
This is the jtd schema that needs to match the input document so that the | ||
test is activated. If this schema doesn't match it normally means that the input | ||
document does not validate against the csaf json schema or optional fields that | ||
the test checks are not present. | ||
*/ | ||
const inputSchema = /** @type {const} */ ({ | ||
additionalProperties: true, | ||
properties: { | ||
document: { | ||
additionalProperties: true, | ||
properties: { | ||
category: { | ||
type: 'string', | ||
}, | ||
}, | ||
optionalProperties: { | ||
lang: { type: 'string' }, | ||
notes: { | ||
elements: { | ||
additionalProperties: true, | ||
optionalProperties: { | ||
category: { | ||
type: 'string', | ||
}, | ||
title: { | ||
type: 'string', | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}) | ||
|
||
const validate = ajv.compile(inputSchema) | ||
|
||
/** | ||
* This implements the mandatory test 6.1.27.18 of the CSAF 2.1 standard. | ||
* | ||
* @param {unknown} doc | ||
*/ | ||
export function mandatoryTest_6_1_27_18(doc) { | ||
/* | ||
The `ctx` variable holds the state that is accumulated during the test ran and is | ||
finally returned by the function. | ||
*/ | ||
const ctx = { | ||
errors: | ||
/** @type {Array<{ instancePath: string; message: string }>} */ ([]), | ||
isValid: true, | ||
} | ||
|
||
if ( | ||
!validate(doc) || | ||
doc.document.category !== 'csaf_superseded' || | ||
// | ||
// The spec says that this test is activated only for documents with the language | ||
// english. Or if the language is unspecified. | ||
(doc.document.lang && | ||
bcp47.parse(doc.document.lang)?.langtag.language.language !== 'en') | ||
) | ||
return ctx | ||
|
||
const reasonTitle = 'Reasoning for Supersession' | ||
|
||
const supersessionNotes = | ||
// Here we filter and map the document notes in one step using `flatMap` | ||
// to avoid double looping through the note array. The category is | ||
// not yet included in the filtering since it is checked below for each note | ||
// individually to improve the error messages. | ||
doc.document.notes?.flatMap((n, i) => | ||
n.title === reasonTitle ? { note: n, index: i } : [] | ||
) ?? [] | ||
|
||
if (supersessionNotes.length !== 1) { | ||
ctx.isValid = false | ||
ctx.errors.push({ | ||
instancePath: `/document/notes`, | ||
message: `needs exactly one entry with the title "${reasonTitle}"`, | ||
}) | ||
} | ||
|
||
for (const { note, index } of supersessionNotes) { | ||
if (note.category !== 'description') { | ||
ctx.isValid = false | ||
ctx.errors.push({ | ||
instancePath: `/document/notes/${index}`, | ||
message: `the category of the "${reasonTitle}" note must be "description"`, | ||
}) | ||
} | ||
} | ||
|
||
return ctx | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import assert from 'node:assert/strict' | ||
import { mandatoryTest_6_1_27_18 } from '../../csaf_2_1/mandatoryTests/mandatoryTest_6_1_27_18.js' | ||
|
||
describe('mandatoryTest_6_1_27_18', function () { | ||
it('only runs on documents matching the input schema', function () { | ||
assert.equal( | ||
mandatoryTest_6_1_27_18({ | ||
document: 'invalid json', | ||
notes: [], | ||
}).isValid, | ||
true | ||
) | ||
}) | ||
|
||
it('only runs on csaf_superseded documents', function () { | ||
assert.equal( | ||
mandatoryTest_6_1_27_18({ | ||
document: { | ||
category: 'unknown category', | ||
}, | ||
notes: [], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it intended that the |
||
}).isValid, | ||
true | ||
) | ||
}) | ||
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intended that the
notes
is outside thedocument
or am I missing something?