Skip to content

feat: add mandatory test 6.1.27.18 #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions csaf_2_1/mandatoryTests.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export { mandatoryTest_6_1_1 } from './mandatoryTests/mandatoryTest_6_1_1.js'
export { mandatoryTest_6_1_8 } from './mandatoryTests/mandatoryTest_6_1_8.js'
export { mandatoryTest_6_1_11 } from './mandatoryTests/mandatoryTest_6_1_11.js'
export { mandatoryTest_6_1_13 } from './mandatoryTests/mandatoryTest_6_1_13.js'
export { mandatoryTest_6_1_27_18 } from './mandatoryTests/mandatoryTest_6_1_27_18.js'
export { mandatoryTest_6_1_34 } from './mandatoryTests/mandatoryTest_6_1_34.js'
export { mandatoryTest_6_1_35 } from './mandatoryTests/mandatoryTest_6_1_35.js'
export { mandatoryTest_6_1_9 } from './mandatoryTests/mandatoryTest_6_1_9.js'
Expand Down
101 changes: 101 additions & 0 deletions csaf_2_1/mandatoryTests/mandatoryTest_6_1_27_18.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
import Ajv from 'ajv/dist/jtd.js'
import bcp47 from 'bcp47'

const ajv = new Ajv()

/*
This is the jtd schema that needs to match the input document so that the
test is activated. If this schema doesn't match it normally means that the input
document does not validate against the csaf json schema or optional fields that
the test checks are not present.
*/
const inputSchema = /** @type {const} */ ({
additionalProperties: true,
properties: {
document: {
additionalProperties: true,
properties: {
category: {
type: 'string',
},
},
optionalProperties: {
lang: { type: 'string' },
notes: {
elements: {
additionalProperties: true,
optionalProperties: {
category: {
type: 'string',
},
title: {
type: 'string',
},
},
},
},
},
},
},
})

const validate = ajv.compile(inputSchema)

/**
* This implements the mandatory test 6.1.27.18 of the CSAF 2.1 standard.
*
* @param {unknown} doc
*/
export function mandatoryTest_6_1_27_18(doc) {
/*
The `ctx` variable holds the state that is accumulated during the test ran and is
finally returned by the function.
*/
const ctx = {
errors:
/** @type {Array<{ instancePath: string; message: string }>} */ ([]),
isValid: true,
}

if (
!validate(doc) ||
doc.document.category !== 'csaf_superseded' ||
//
// The spec says that this test is activated only for documents with the language
// english. Or if the language is unspecified.
(doc.document.lang &&
bcp47.parse(doc.document.lang)?.langtag.language.language !== 'en')
)
return ctx

const reasonTitle = 'Reasoning for Supersession'

const supersessionNotes =
// Here we filter and map the document notes in one step using `flatMap`
// to avoid double looping through the note array. The category is
// not yet included in the filtering since it is checked below for each note
// individually to improve the error messages.
doc.document.notes?.flatMap((n, i) =>
n.title === reasonTitle ? { note: n, index: i } : []
) ?? []

if (supersessionNotes.length !== 1) {
ctx.isValid = false
ctx.errors.push({
instancePath: `/document/notes`,
message: `needs exactly one entry with the title "${reasonTitle}"`,
})
}

for (const { note, index } of supersessionNotes) {
if (note.category !== 'description') {
ctx.isValid = false
ctx.errors.push({
instancePath: `/document/notes/${index}`,
message: `the category of the "${reasonTitle}" note must be "description"`,
})
}
}

return ctx
}
26 changes: 26 additions & 0 deletions tests/csaf_2_1/mandatoryTest_6_1_27_18.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import assert from 'node:assert/strict'
import { mandatoryTest_6_1_27_18 } from '../../csaf_2_1/mandatoryTests/mandatoryTest_6_1_27_18.js'

describe('mandatoryTest_6_1_27_18', function () {
it('only runs on documents matching the input schema', function () {
assert.equal(
mandatoryTest_6_1_27_18({
document: 'invalid json',
notes: [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended that the notes is outside the document or am I missing something?

}).isValid,
true
)
})

it('only runs on csaf_superseded documents', function () {
assert.equal(
mandatoryTest_6_1_27_18({
document: {
category: 'unknown category',
},
notes: [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended that the notes is outside the document or am I missing something?

}).isValid,
true
)
})
})
1 change: 0 additions & 1 deletion tests/csaf_2_1/oasis.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const excluded = [
'6.1.27.15',
'6.1.27.16',
'6.1.27.17',
'6.1.27.18',
'6.1.27.19',
'6.1.37',
'6.1.42',
Expand Down
Loading