feat: add mandatory test 6.1.27.17 #342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschmidtb51
requested changes
Jun 18, 2025
| assert.equal( | ||
| mandatoryTest_6_1_27_17({ | ||
| document: 'invalid json', | ||
| notes: [], |
There was a problem hiding this comment.
Is it intended that the notes is outside the document or am I missing something?
| document: { | ||
| category: 'unknown category', | ||
| }, | ||
| notes: [], |
There was a problem hiding this comment.
Is it intended that the notes is outside the document or am I missing something?
|
Don't forget to update the README - removing it from the known issues and placing it into the supported tests. |
tschmidtb51
reviewed
Jun 18, 2025
| // not yet included in the filtering since it is checked below for each note | ||
| // individually to improve the error messages. | ||
| doc.document.notes?.flatMap((n, i) => | ||
| n.title === 'Reasoning for Withdrawal' ? { note: n, index: i } : [] |
There was a problem hiding this comment.
Maybe similar to the implementation in #343 as variable?
tschmidtb51
reviewed
Jun 18, 2025
| ctx.errors.push({ | ||
| instancePath: `/document/notes/${index}`, | ||
| message: | ||
| 'the category of the "Reasoning for Withdrawal" note must be "description"', |
tschmidtb51
reviewed
Jun 18, 2025
| ctx.errors.push({ | ||
| instancePath: `/document/notes`, | ||
| message: | ||
| 'needs exactly one entry with the title "Reasoning for Withdrawal"', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.