-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add mandatory test 6.1.27.15 #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments
optionalProperties: { | ||
product_tree: { | ||
additionalProperties: true, | ||
properties: {}, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does that make sense? We want to check that it doesn't exist... - Maybe, I'm missing something.
assert.equal( | ||
mandatoryTest_6_1_27_15({ | ||
document: 'invalid json', | ||
product_tree: [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't that always validate as the check goes against an object
, not an array
?
ctx.errors.push({ | ||
instancePath: `/product_tree`, | ||
message: | ||
'the product_tree is not allowed in the specified document category', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'the product_tree is not allowed in the specified document category', | |
'must not exist in the specified document category', |
No description provided.