-
Notifications
You must be signed in to change notification settings - Fork 9
docs: update readme for csaf 2.1 experimental release #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update the README to cover:
- known issues
- known unimplemented tests (easy to miss them in a long list)
- optional tests are renamed into recommended in CSAF 2.1
- update the list of dependencies (if necessary)
518d33e
to
51ff63f
Compare
Coverage after merging 196-csaf-2.1-experimental-notice into 196-csaf-2.1
Coverage Report
|
Thanks for having a look. I updated the readme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at my comments.
Please also add to the list of known issue that the CVSS 4.0 computation is still under debate as it it unclear from the specification how to compute threatScore
and environmentalScore
.
If you do the release, please also document that the scripts
(runTests.js
and I guess the cwe as well?) changed...
51ff63f
to
2c70141
Compare
Okay, thanks I fixed the issues |
Coverage after merging 196-csaf-2.1-experimental-notice into 196-csaf-2.1
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I miss the changed for:
Please also add to the list of known issue that the CVSS 4.0 computation is still under debate as it it unclear from the specification how to compute threatScore and environmentalScore.
If you do the release, please also document that the scripts (runTests.js and I guess the cwe as well?) changed...
Coverage after merging 196-csaf-2.1-experimental-notice into 196-csaf-2.1
Coverage Report
|
This PR updates the documentation for the experimental inclusion of the CSAF 2.1 tests in the
main
branch.@tschmidtb51 Can you have a look at the wording?