Skip to content

Feat/199 informative tests csaf2.1 6.3.2 #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csaf_2_1/informativeTests.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
export {
informativeTest_6_3_2,
informativeTest_6_3_3,
informativeTest_6_3_5,
informativeTest_6_3_6,
Expand All @@ -11,3 +10,4 @@ export {
} from '../informativeTests.js'
export { informativeTest_6_3_1 } from './informativeTests/informativeTest_6_3_1.js'
export { informativeTest_6_3_4 } from './informativeTests/informativeTest_6_3_4.js'
export { informativeTest_6_3_2 } from './informativeTests/informativeTest_6_3_2.js'
72 changes: 72 additions & 0 deletions csaf_2_1/informativeTests/informativeTest_6_3_2.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
import Ajv from 'ajv/dist/jtd.js'

const ajv = new Ajv()

const inputSchema = /** @type {const} */ ({
additionalProperties: true,
properties: {
vulnerabilities: {
elements: {
additionalProperties: true,
optionalProperties: {
metrics: {
elements: {
additionalProperties: true,
optionalProperties: {
content: {
additionalProperties: true,
optionalProperties: {
cvss_v3: {
additionalProperties: true,
optionalProperties: {
version: { type: 'string' },
vectorString: { type: 'string' },
},
},
},
},
},
},
},
},
},
},
},
})

const validateInput = ajv.compile(inputSchema)

/**
* For each item in the list of metrics which contains the cvss_v3 object under
* content it MUST be tested that CVSS v3.0 is not used.
* @param {unknown} doc
* @returns
*/
export function informativeTest_6_3_2(doc) {
const ctx = {
infos: /** @type {Array<{ message: string; instancePath: string }>} */ ([]),
}

if (!validateInput(doc)) {
return ctx
}

doc.vulnerabilities.forEach((vulnerability, vulnerabilityIndex) => {
const metrics = vulnerability.metrics
metrics?.forEach((metric, metricIndex) => {
if (metric.content?.cvss_v3) {
if (
metric.content.cvss_v3.version === '3.0' ||
metric.content.cvss_v3.vectorString?.startsWith('CVSS:3.0')
) {
ctx.infos.push({
instancePath: `/vulnerabilities/${vulnerabilityIndex}/metrics/${metricIndex}/content/cvss_v3/version`,
message: 'It is recommended to upgrade to CVSS v3.1.',
})
}
}
})
})

return ctx
}
30 changes: 30 additions & 0 deletions tests/csaf_2_1/informativeTest_6_3_2.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import assert from 'node:assert/strict'
import { informativeTest_6_3_2 } from '../../csaf_2_1/informativeTests/informativeTest_6_3_2.js'

describe('informativeTest_6_3_2', function () {
it('only runs on relevant documents', function () {
assert.equal(informativeTest_6_3_2({ document: 'mydoc' }).infos.length, 0)
})
it('test input schema with not considered json object in vulnerabilities', function () {
assert.equal(
informativeTest_6_3_2({
document: {},
vulnerabilities: [
{},
{
metrics: [
{
content: {
cvss_v3: {
version: '3.0',
},
},
},
],
},
],
}).infos.length,
1
)
})
})
1 change: 0 additions & 1 deletion tests/csaf_2_1/oasis.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ const excluded = [
'6.2.44',
'6.2.45',
'6.2.46',
'6.3.2',
'6.3.14',
'6.3.15',
'6.3.12',
Expand Down