-
Notifications
You must be signed in to change notification settings - Fork 9
Feat/199 informative tests csaf2.1 6.3.2 #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rainer-exxcellent
merged 2 commits into
main
from
feat/199-Informative-Tests_CSAF2_1_6.3.2
Jun 24, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
import Ajv from 'ajv/dist/jtd.js' | ||
|
||
const ajv = new Ajv() | ||
|
||
const inputSchema = /** @type {const} */ ({ | ||
additionalProperties: true, | ||
properties: { | ||
vulnerabilities: { | ||
elements: { | ||
additionalProperties: true, | ||
optionalProperties: { | ||
metrics: { | ||
elements: { | ||
additionalProperties: true, | ||
optionalProperties: { | ||
content: { | ||
additionalProperties: true, | ||
optionalProperties: { | ||
cvss_v3: { | ||
additionalProperties: true, | ||
optionalProperties: { | ||
version: { type: 'string' }, | ||
vectorString: { type: 'string' }, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}) | ||
|
||
const validateInput = ajv.compile(inputSchema) | ||
|
||
/** | ||
* For each item in the list of metrics which contains the cvss_v3 object under | ||
* content it MUST be tested that CVSS v3.0 is not used. | ||
* @param {unknown} doc | ||
* @returns | ||
*/ | ||
export function informativeTest_6_3_2(doc) { | ||
const ctx = { | ||
infos: /** @type {Array<{ message: string; instancePath: string }>} */ ([]), | ||
} | ||
|
||
if (!validateInput(doc)) { | ||
return ctx | ||
} | ||
|
||
doc.vulnerabilities.forEach((vulnerability, vulnerabilityIndex) => { | ||
const metrics = vulnerability.metrics | ||
metrics?.forEach((metric, metricIndex) => { | ||
if (metric.content?.cvss_v3) { | ||
if ( | ||
metric.content.cvss_v3.version === '3.0' || | ||
metric.content.cvss_v3.vectorString?.startsWith('CVSS:3.0') | ||
) { | ||
ctx.infos.push({ | ||
instancePath: `/vulnerabilities/${vulnerabilityIndex}/metrics/${metricIndex}/content/cvss_v3/version`, | ||
message: 'It is recommended to upgrade to CVSS v3.1.', | ||
}) | ||
} | ||
} | ||
}) | ||
}) | ||
|
||
return ctx | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import assert from 'node:assert/strict' | ||
import { informativeTest_6_3_2 } from '../../csaf_2_1/informativeTests/informativeTest_6_3_2.js' | ||
|
||
describe('informativeTest_6_3_2', function () { | ||
it('only runs on relevant documents', function () { | ||
assert.equal(informativeTest_6_3_2({ document: 'mydoc' }).infos.length, 0) | ||
}) | ||
it('test input schema with not considered json object in vulnerabilities', function () { | ||
assert.equal( | ||
informativeTest_6_3_2({ | ||
document: {}, | ||
vulnerabilities: [ | ||
{}, | ||
{ | ||
metrics: [ | ||
{ | ||
content: { | ||
cvss_v3: { | ||
version: '3.0', | ||
}, | ||
}, | ||
}, | ||
], | ||
}, | ||
], | ||
}).infos.length, | ||
1 | ||
) | ||
}) | ||
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,7 +71,6 @@ const excluded = [ | |
'6.2.44', | ||
'6.2.45', | ||
'6.2.46', | ||
'6.3.2', | ||
'6.3.14', | ||
'6.3.15', | ||
'6.3.12', | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.