-
Notifications
You must be signed in to change notification settings - Fork 9
feat(CSAF2.1): #196 add optionalTest_6_2_30.js #265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Coverage after merging 196-csaf-2.1_optional_test_6.2.30 into 196-csaf-2.1
Coverage Report |
Coverage after merging 196-csaf-2.1_optional_test_6.2.30 into 196-csaf-2.1
Coverage Report |
899eb2a
to
8d641d7
Compare
Coverage after merging 196-csaf-2.1_optional_test_6.2.30 into 196-csaf-2.1
Coverage Report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also keep the `
vs '
consistent in all tests.
83ffc34
to
96a95a4
Compare
Coverage after merging 196-csaf-2.1_optional_test_6.2.30 into 196-csaf-2.1
Coverage Report
|
e71b653
to
1327360
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment. Please double check. Other LGTM.
If you just improve the ?
question, no additional review from me is needed
1327360
to
c4890ce
Compare
Coverage after merging 196-csaf-2.1_optional_test_6.2.30 into main
Coverage Report
|
c4890ce
to
8ce925e
Compare
Coverage after merging 196-csaf-2.1_optional_test_6.2.30 into main
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test which validates that input schema only runs on relevant documents
and move the test in the README to the supported tests.
Rebase to the latest main.
Co-authored-by: tschmidtb51 <65305130+tschmidtb51@users.noreply.github.com>
8ce925e
to
c21d44a
Compare
Coverage after merging 196-csaf-2.1_optional_test_6.2.30 into main
Coverage Report
|
@@ -463,6 +463,10 @@ export const recommendedTest_6_2_18: DocumentTest | |||
export const recommendedTest_6_2_19: DocumentTest | |||
export const recommendedTest_6_2_20: DocumentTest | |||
export const recommendedTest_6_2_22: DocumentTest | |||
export const recommendedTest_6_2_27: DocumentTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the test from the not yet implemented tests in #### Known Issues
c21d44a
to
6614f14
Compare
Coverage after merging 196-csaf-2.1_optional_test_6.2.30 into main
Coverage Report
|
No description provided.