-
Notifications
You must be signed in to change notification settings - Fork 9
196 csaf 2.1 optional test 6.2.29 #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage after merging 196-csaf-2.1_optional_test_6.2.29 into 196-csaf-2.1
Coverage Report |
Coverage after merging 196-csaf-2.1_optional_test_6.2.29 into 196-csaf-2.1
Coverage Report |
edb8372
to
304c1f0
Compare
Coverage after merging 196-csaf-2.1_optional_test_6.2.29 into 196-csaf-2.1
Coverage Report |
1 similar comment
Coverage after merging 196-csaf-2.1_optional_test_6.2.29 into 196-csaf-2.1
Coverage Report |
304c1f0
to
3b4afff
Compare
Coverage after merging 196-csaf-2.1_optional_test_6.2.29 into 196-csaf-2.1
Coverage Report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments - basically the same as in https://github.com/secvisogram/csaf-validator-lib/pull/258/files applies.
Also, it needs to be consistent with 6.2.28 (and other sharing_group
tests).
0cd4b99
to
ec7b564
Compare
Coverage after merging 196-csaf-2.1_optional_test_6.2.29 into 196-csaf-2.1
Coverage Report
|
ec7b564
to
cc10ff3
Compare
Coverage after merging 196-csaf-2.1_optional_test_6.2.29 into 196-csaf-2.1
Coverage Report
|
7e3f6cf
to
903110c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
message: 'The Nil UUID should not be used as sharing group id.', | ||
instancePath: '/document/distribution/sharing_group/id', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the order consistant
903110c
to
2dc6423
Compare
Coverage after merging 196-csaf-2.1_optional_test_6.2.29 into 196-csaf-2.1
Coverage Report
|
2dc6423
to
734d207
Compare
Coverage after merging 196-csaf-2.1_optional_test_6.2.29 into 196-csaf-2.1
Coverage Report
|
No description provided.