-
Notifications
You must be signed in to change notification settings - Fork 9
Feat/#197 mandatory tests csaf2.1 6.1.7 #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/#197 mandatory tests csaf2.1 6.1.7 #208
Conversation
I'll review after #220 is merged |
4d52335
to
aa7a7c5
Compare
2038db4
to
c319007
Compare
Coverage after merging feat/#197-Mandatory_Tests_CSAF2_1_6.1.7 into 196-csaf-2.1
Coverage Report
|
Coverage after merging feat/#197-Mandatory_Tests_CSAF2_1_6.1.7 into 196-csaf-2.1
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments.
Idea: Would the error message be more helpful, if we would provide details, where it was already used?
55343d9
to
6e98047
Compare
Coverage after merging feat/#197-Mandatory_Tests_CSAF2_1_6.1.7 into 196-csaf-2.1
Coverage Report
|
6e98047
to
2e7bd89
Compare
Coverage after merging feat/#197-Mandatory_Tests_CSAF2_1_6.1.7 into 196-csaf-2.1
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not take source
into account: oasis-tcs/csaf#943
2e7bd89
to
40b8082
Compare
Coverage after merging feat/#197-Mandatory_Tests_CSAF2_1_6.1.7 into 196-csaf-2.1
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an editorial nit - other than that: LGTM.
(If you fix it in a separate commit, the approve should be fast ;-))
… supported tests
Coverage after merging feat/#197-Mandatory_Tests_CSAF2_1_6.1.7 into main
Coverage Report
|
Co-authored-by: tschmidtb51 <65305130+tschmidtb51@users.noreply.github.com>
Coverage after merging feat/#197-Mandatory_Tests_CSAF2_1_6.1.7 into main
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pull request is already approved by 2 persons
#197 copy and adapt mandatory test 6.1.7 from CSAF 2.0 to CSAF 2.1