Skip to content

Properly warn when scaling textures down instead of being entirely silent. #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2025
Merged

Properly warn when scaling textures down instead of being entirely silent. #4404

merged 1 commit into from
Jul 22, 2025
+94 −17

Conversation

akleshchev
Copy link
Contributor

@akleshchev akleshchev commented Jul 21, 2025 •
edited
Loading

  1. Notification for material upload through floater (bulk upload not covered)
  2. Uploader Log for model upload
  3. Incidentaly also fixes a problem where preview won't wait for textures to load

@akleshchev akleshchev changed the base branch from geenz/gltf-mesh-import to release/2025.05 July 21, 2025 23:03
@akleshchev akleshchev linked an issue Jul 21, 2025 that may be closed by this pull request
Material, not supported image size #4318
Open
@maxim-productengine
Copy link
Contributor

maxim-productengine commented Jul 21, 2025 •
edited
Loading

Needs a way to be localizable

We may place this log text to strings.xml

@vldevel
Copy link
Contributor

vldevel commented Jul 22, 2025

The best place for a localized text would be in the floater_model_preview.xml XUI definition itself.

Note that there are a lot other reports added to the mesh upload preview floater log tab and that are hard-coded as English strings: this would need a general cleanup for proper localization.

@akleshchev
#4318 Warn or log when texture gets scaled down
9942986 
for material and model upload
@akleshchev akleshchev force-pushed the andreyk/viewer_4318 branch from bdd00e7 to 9942986 Compare July 22, 2025 14:14
@akleshchev
Copy link
Contributor Author

Added localization support for this specific log message, not for general output.

@akleshchev akleshchev merged commit d848979 into release/2025.05 Jul 22, 2025
13 checks passed
@akleshchev akleshchev deleted the andreyk/viewer_4318 branch July 22, 2025 16:16
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marchcat marchcat marchcat approved these changes

@maxim-productengine maxim-productengine maxim-productengine approved these changes

Assignees
No one assigned
Labels
c/cpp llprimitive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Material, not supported image size
4 participants
@akleshchev @maxim-productengine @vldevel @marchcat