Add missing @no-named-arguments annotations and ensure there won't be new missing ones anymore

.github/workflows/ci.yaml

@@ -60,7 +60,7 @@ jobs:
           tools: none
 
       - name: Run PHP-CS-Fixer
-        run: ./tools/php-cs-fixer fix --dry-run --show-progress=dots --using-cache=no --verbose
+        run: ./tools/php-cs-fixer check --show-progress=dots --using-cache=no --verbose
 
   static-analysis:
     name: Static Analysis

.php-cs-fixer.dist.php

@@ -8,6 +8,8 @@
 file that was distributed with this source code.
 EOF;
 
+require __DIR__ . '/tools/.php-cs-fixer/vendor/kubawerlos/php-cs-fixer-custom-fixers/bootstrap.php';
+
 $finder = PhpCsFixer\Finder::create()
     ->files()
     ->in(__DIR__ . '/src')
@@ -29,6 +31,7 @@
 
 $config = new PhpCsFixer\Config;
 $config->setFinder($finder)
+    ->registerCustomFixers(new PhpCsFixerCustomFixers\Fixers)
     ->setRiskyAllowed(true)
     ->setRules([
         'align_multiline_comment' => true,
@@ -371,6 +374,11 @@
         ],
         'void_return' => true,
         'whitespace_after_comma_in_array' => true,
+        PhpCsFixerCustomFixers\Fixer\PhpdocTagNoNamedArgumentsFixer::name() => [
+            'directory' => __DIR__ . '/src/',
+            'description' => 'Parameter names are not covered by the backward compatibility promise for PHPUnit'
+        ]
+
     ]);
 
 $config->setCacheFile(__DIR__ . '/.php-cs-fixer.cache/' . json_decode((string) @file_get_contents('composer.json'), true)["extra"]["branch-alias"]["dev-main"] ?? 'unknown');

src/Event/Exception/Exception.php

@@ -9,6 +9,9 @@
  */
 namespace PHPUnit\Event;
 
+/**
+ * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
+ */
 interface Exception extends \PHPUnit\Exception
 {
 }

src/Exception.php

@@ -11,6 +11,9 @@
 
 use Throwable;
 
+/**
+ * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
+ */
 interface Exception extends Throwable
 {
 }

src/Framework/TestRunner/ChildProcessResultProcessor.php

@@ -19,6 +19,9 @@
 use PHPUnit\Runner\CodeCoverage;
 use PHPUnit\TestRunner\TestResult\PassedTests;
 
+/**
+ * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
+ */
 final readonly class ChildProcessResultProcessor
 {
     private Facade $eventFacade;

src/Metadata/Exception/Exception.php

@@ -9,6 +9,9 @@
  */
 namespace PHPUnit\Metadata;
 
+/**
+ * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
+ */
 interface Exception extends \PHPUnit\Exception
 {
 }

src/Metadata/Exception/InvalidVersionRequirementException.php

@@ -11,6 +11,9 @@
 
 use RuntimeException;
 
+/**
+ * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
+ */
 final class InvalidVersionRequirementException extends RuntimeException implements Exception
 {
 }

src/Metadata/Exception/NoVersionRequirementException.php

@@ -11,6 +11,9 @@
 
 use RuntimeException;
 
+/**
+ * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
+ */
 final class NoVersionRequirementException extends RuntimeException implements Exception
 {
 }

src/TextUI/Output/Default/UnexpectedOutputPrinter.php

@@ -16,6 +16,9 @@
 use PHPUnit\Event\UnknownSubscriberTypeException;
 use PHPUnit\TextUI\Output\Printer;
 
+/**
+ * @no-named-arguments Parameter names are not covered by the backward compatibility promise for PHPUnit
+ */
 final readonly class UnexpectedOutputPrinter implements PrintedUnexpectedOutputSubscriber
 {
     private Printer $printer;

tools/.php-cs-fixer/composer.json

@@ -0,0 +1,6 @@
+{
+    "require-dev": {
+        "kubawerlos/php-cs-fixer-custom-fixers": "^3.27",
+        "php-cs-fixer/shim": "^3.75"
+    }
+}

tools/.php-cs-fixer/vendor/autoload.php

@@ -0,0 +1,22 @@
+<?php
+
+// autoload.php @generated by Composer
+
+if (PHP_VERSION_ID < 50600) {
+    if (!headers_sent()) {
+        header('HTTP/1.1 500 Internal Server Error');
+    }
+    $err = 'Composer 2.3.0 dropped support for autoloading on PHP <5.6 and you are running '.PHP_VERSION.', please upgrade PHP or use Composer 2.2 LTS via "composer self-update --2.2". Aborting.'.PHP_EOL;
+    if (!ini_get('display_errors')) {
+        if (PHP_SAPI === 'cli' || PHP_SAPI === 'phpdbg') {
+            fwrite(STDERR, $err);
+        } elseif (!headers_sent()) {
+            echo $err;
+        }
+    }
+    throw new RuntimeException($err);
+}
+
+require_once __DIR__ . '/composer/autoload_real.php';
+
+return ComposerAutoloaderInit3457f0272a028217b66ee19b6e4c5737::getLoader();

tools/.php-cs-fixer/vendor/bin/php-cs-fixer

@@ -0,0 +1,119 @@
+#!/usr/bin/env php
+<?php
+
+/**
+ * Proxy PHP file generated by Composer
+ *
+ * This file includes the referenced bin path (../php-cs-fixer/shim/php-cs-fixer)
+ * using a stream wrapper to prevent the shebang from being output on PHP<8
+ *
+ * @generated
+ */
+
+namespace Composer;
+
+$GLOBALS['_composer_bin_dir'] = __DIR__;
+$GLOBALS['_composer_autoload_path'] = __DIR__ . '/..'.'/autoload.php';
+
+if (PHP_VERSION_ID < 80000) {
+    if (!class_exists('Composer\BinProxyWrapper')) {
+        /**
+         * @internal
+         */
+        final class BinProxyWrapper
+        {
+            private $handle;
+            private $position;
+            private $realpath;
+
+            public function stream_open($path, $mode, $options, &$opened_path)
+            {
+                // get rid of phpvfscomposer:// prefix for __FILE__ & __DIR__ resolution
+                $opened_path = substr($path, 17);
+                $this->realpath = realpath($opened_path) ?: $opened_path;
+                $opened_path = $this->realpath;
+                $this->handle = fopen($this->realpath, $mode);
+                $this->position = 0;
+
+                return (bool) $this->handle;
+            }
+
+            public function stream_read($count)
+            {
+                $data = fread($this->handle, $count);
+
+                if ($this->position === 0) {
+                    $data = preg_replace('{^#!.*\r?\n}', '', $data);
+                }
+
+                $this->position += strlen($data);
+
+                return $data;
+            }
+
+            public function stream_cast($castAs)
+            {
+                return $this->handle;
+            }
+
+            public function stream_close()
+            {
+                fclose($this->handle);
+            }
+
+            public function stream_lock($operation)
+            {
+                return $operation ? flock($this->handle, $operation) : true;
+            }
+
+            public function stream_seek($offset, $whence)
+            {
+                if (0 === fseek($this->handle, $offset, $whence)) {
+                    $this->position = ftell($this->handle);
+                    return true;
+                }
+
+                return false;
+            }
+
+            public function stream_tell()
+            {
+                return $this->position;
+            }
+
+            public function stream_eof()
+            {
+                return feof($this->handle);
+            }
+
+            public function stream_stat()
+            {
+                return array();
+            }
+
+            public function stream_set_option($option, $arg1, $arg2)
+            {
+                return true;
+            }
+
+            public function url_stat($path, $flags)
+            {
+                $path = substr($path, 17);
+                if (file_exists($path)) {
+                    return stat($path);
+                }
+
+                return false;
+            }
+        }
+    }
+
+    if (
+        (function_exists('stream_get_wrappers') && in_array('phpvfscomposer', stream_get_wrappers(), true))
+        || (function_exists('stream_wrapper_register') && stream_wrapper_register('phpvfscomposer', 'Composer\BinProxyWrapper'))
+    ) {
+        return include("phpvfscomposer://" . __DIR__ . '/..'.'/php-cs-fixer/shim/php-cs-fixer');
+    }
+}
+
+return include __DIR__ . '/..'.'/php-cs-fixer/shim/php-cs-fixer';

tools/.php-cs-fixer/vendor/bin/php-cs-fixer.bat

@@ -0,0 +1,5 @@
+@ECHO OFF
+setlocal DISABLEDELAYEDEXPANSION
+SET BIN_TARGET=%~dp0/php-cs-fixer
+SET COMPOSER_RUNTIME_BIN_DIR=%~dp0
+php "%BIN_TARGET%" %*